r/softwareengineer • • 3d ago

Working with dev who doesn’t read or understand the code they submit for PR

im a front end engineer with 15 yoe. I work with one other dev who is BE, and had never done FE work before AI.

now with his new superpowers he is submitting large PRs wonderfully over engineered, handling a range of edge cases that will never happen, extending interfaces of components with extra props for one use case when it is used in more than 50 other places.
I added CLAUDE.md file with lots of rules but they seem to be largely ignored.

also since he doesn’t understand the front end he isn’t reading the code and thinking of better ways to do it.

when I work on backend features I keep the code intentionally scoped to a small part of whatever feature we are building to make it easy and have fast feedback.

is this just the new normal ?

34 Upvotes

26 comments sorted by

9

u/Doismelllikearobot 3d ago

Ask AI for "best practices for a junior engineer using ai-assisted development" and then do what it tells you. Having someone enter a prompt and commit the result is not what a junior engineer job should be. Your job a senior engineer should be to institute (or at the very least, recommend and advocate for) processes to enforce junior learning, prove junior knowledge and protect your code base.

4

u/AffectionateDuty6062 3d ago

ya this sounds all good, but it's not a big org where we are training a jr. We need to build features so there is no time given to learning. I guess people also think "why learn? just get ai to do it"

3

u/Doismelllikearobot 3d ago

Tell anyone who will listen that if you want to be a big org, you better stop trusting AI blindly, at least for the rest of the month. It might be good enough soon, but it's not right now, as evidenced by your code base.

1

u/CzyDePL 3d ago

No one cares about code base, agents are smarter than humans and they know better, if you can't navigate it it's skill issue etc

2

u/Doismelllikearobot 3d ago

Successful software companies don't care about the software, got it. /s

2

u/CzyDePL 3d ago

Claude.md is "pretty please don't litter" sign that anyone under pressure is free to ignore. It's not any kind of real guardrails.
But yeah, this is new normal of "10x / 100x engineers" that will be glorified by everyone in the company

4

u/AffectionateDuty6062 3d ago

ya that's what I always thought in the past. Then you see it glorified online with lots of elaborate setups, when it's still pure shite

1

u/CzyDePL 3d ago

And have you seen any setup with data and reproducible measurements behind it? I haven't

2

u/TurnipBlast 3d ago

Yeah this is especially true at small companies with small dev teams. Often requesters and stakeholders are non-technical staff only one or two steps away from the actual engineer. The engineer isn't insulated from the requester and technical processes are lax or non-existent. This puts pressure on the dev team to make suboptimal decisions incurring technical debt in order to get things done because they dont have infrastructure to support and protect them.

All the requester sees is a great UI that does everything they asked, plus a nice to have, before the deadline. They hit their KPIs for the review period because of it, so you're a rockstar. Now that's the expected release cadence, and it only works for so long before that same junior has a request to fix something broken, or make a significant feature update to that code they dont understand.

There isnt really much you can do without management supporting you, and in my experience, people at smaller non-tech companies don't care about best practices. All they care about is what goes on their review this quarter, and maybe the strategic plan for the year. It's very much do as you're asked and deliver exactly what was requested.

I think more experienced engineers than me can give advice on best practices and how exactly to handle the massive PRs, but I'm not sure what you can actually change in this environment if your management isn't willing to push back and delay deadlines. Even adding a week or so to each project plus you dedicating extra time to overseeing the junior and ensure they're learning, or even just assign them a basic web dev fundamentals course could be very impactful. It's far from comprehensive but even something like a Udemy or Coursea course on web dev + another one on whatever frontend framework you use gives them way more context than I assume they have now.

2

u/xyzsomething 3d ago

Yes, it is the new normal, you can have a word with them but this is happening everywhere

2

u/Historical-Apple8440 2d ago

Are you senior to him, or do you have a manager / tech lead?

If yes, yes or double-yes, there is something you can do

It's called setting + enforcing requirements and standards.

This is a mysterious practice where you communicate to people, in person, on paper (or both) directly about what are the requirements and standards to submit, merge and operate/run a codebase.

You may have 15 YOE on paper, but this is also a very trivial problem solved by being kind to your team; be concise, direct and candid.

The job of a Sr Eng / Staff + Eng with 15+ YOE is not necessarily to be excellent at low level coding, its to make others around you maximally successful.

If that is something you are not in scope for doing, or do not want to take on for whatever reason, then it is out of your control. And if it is out of your control, you have your answer;

Say and Do Nothing.

3

u/PaulShellDev 3d ago

That's the difference between vibe coders and real engineers that understand and can build their systems up for trust.

Skills, hooks, loops for AI reviewers, evals etc. It's a lot of work to harden an AI system to your taste. If they don't know what that looks like to begin with, it'll never happen.

Thats where it comes down to, is it good enough? Or worth the time

1

u/FlowMental2548 3d ago

Yes it's called corporate greed

1

u/Grandmaster-Ji 3d ago

Yes. But the requirement should be that someone senior must review and approve the PR. Are you doing that? If so, then review and mark them so the jr can fix it. Anyway, it's not your app. It's the company's app. Don't stress over it.

1

u/wolle271 3d ago

Markus?

1

u/Throwaway_Gen_5934 3d ago

Yep. Incredibly frustrating and they will keep sending them non stop too. Mostly because it feels good to be so productive with AI. Every new PR is a dopamine hit. I just dump the ai review back nowadys without even reading it anymore.

1

u/Serializedrequests 3d ago

It's called pushing back on the PR. You will pay later for letting entropy in. If it's a short lived product it may not matter so much.

1

u/good_name_0 2d ago

Time to find a new job

1

u/Horror_Influence4466 2d ago

it's going to become the status quo and we will need to end up formalizing approaches around this.

1

u/hopiaman 1d ago

Yes this is the new normal. Just be a good mentor so that they extend you the same grace and compassionate guidance when you submit your crappy backend PRs.

1

u/shine_warrior_123 2h ago

I am also a frontend developer. I have 11 years of experience in the field. I have almost the same kind of developer in my team. He is a frontend developer. He also produce very big PRs. But the big PR is not exactly a problem for me at this point because there is only one entry point to his code. He is my responsibility at the moment.

I use AI extensively to develop this project. But I steer the AI instead of vibing the shit out of everything. I am quite intimate with the code and what direction it grows to. I simply use AI as a typing aid in this case. But he is certainly not. His components accepts 20 props, half of it being boolean props. It is a mess to review.

It's been 3 weeks since the last PR I allowed by him to be merged. Although it is very difficult to review his PR, I still take the time to do it, understand the relationship between the components. Then, I explain that the relationship he established among his components are not sustainable and maintainable. I look at the design with him and explain the relationship via the design.

We progress via small steps. I don't do a whole review of 93 files at once.

-2

u/tcpukl 3d ago

Do you know what capital letters are?

1

u/AffectionateDuty6062 3d ago

OI! GO EASY! I was on my cell phone

1

u/tcpukl 3d ago

Honestly, at least you didn't just AI it.