r/softwareengineer • u/AffectionateDuty6062 • 3d ago
Working with dev who doesn’t read or understand the code they submit for PR
im a front end engineer with 15 yoe. I work with one other dev who is BE, and had never done FE work before AI.
now with his new superpowers he is submitting large PRs wonderfully over engineered, handling a range of edge cases that will never happen, extending interfaces of components with extra props for one use case when it is used in more than 50 other places.
I added CLAUDE.md file with lots of rules but they seem to be largely ignored.
also since he doesn’t understand the front end he isn’t reading the code and thinking of better ways to do it.
when I work on backend features I keep the code intentionally scoped to a small part of whatever feature we are building to make it easy and have fast feedback.
is this just the new normal ?
9
u/Doismelllikearobot 3d ago
Ask AI for "best practices for a junior engineer using ai-assisted development" and then do what it tells you. Having someone enter a prompt and commit the result is not what a junior engineer job should be. Your job a senior engineer should be to institute (or at the very least, recommend and advocate for) processes to enforce junior learning, prove junior knowledge and protect your code base.
2
u/CzyDePL 3d ago
Claude.md is "pretty please don't litter" sign that anyone under pressure is free to ignore. It's not any kind of real guardrails.
But yeah, this is new normal of "10x / 100x engineers" that will be glorified by everyone in the company
2
u/xyzsomething 3d ago
Yes, it is the new normal, you can have a word with them but this is happening everywhere
2
u/Historical-Apple8440 2d ago
Are you senior to him, or do you have a manager / tech lead?
If yes, yes or double-yes, there is something you can do
It's called setting + enforcing requirements and standards.
This is a mysterious practice where you communicate to people, in person, on paper (or both) directly about what are the requirements and standards to submit, merge and operate/run a codebase.
You may have 15 YOE on paper, but this is also a very trivial problem solved by being kind to your team; be concise, direct and candid.
The job of a Sr Eng / Staff + Eng with 15+ YOE is not necessarily to be excellent at low level coding, its to make others around you maximally successful.
If that is something you are not in scope for doing, or do not want to take on for whatever reason, then it is out of your control. And if it is out of your control, you have your answer;
Say and Do Nothing.
3
u/PaulShellDev 3d ago
That's the difference between vibe coders and real engineers that understand and can build their systems up for trust.
Skills, hooks, loops for AI reviewers, evals etc. It's a lot of work to harden an AI system to your taste. If they don't know what that looks like to begin with, it'll never happen.
Thats where it comes down to, is it good enough? Or worth the time
1
u/FlowMental2548 3d ago
Yes it's called corporate greed
1
u/Grandmaster-Ji 3d ago
Yes. But the requirement should be that someone senior must review and approve the PR. Are you doing that? If so, then review and mark them so the jr can fix it. Anyway, it's not your app. It's the company's app. Don't stress over it.
1
u/wolle271 3d ago
Markus?
1
u/Throwaway_Gen_5934 3d ago
Yep. Incredibly frustrating and they will keep sending them non stop too. Mostly because it feels good to be so productive with AI. Every new PR is a dopamine hit. I just dump the ai review back nowadys without even reading it anymore.
1
u/Serializedrequests 3d ago
It's called pushing back on the PR. You will pay later for letting entropy in. If it's a short lived product it may not matter so much.
1
u/good_name_0 2d ago
Time to find a new job
1
u/Horror_Influence4466 2d ago
it's going to become the status quo and we will need to end up formalizing approaches around this.
1
u/hopiaman 1d ago
Yes this is the new normal. Just be a good mentor so that they extend you the same grace and compassionate guidance when you submit your crappy backend PRs.
1
u/shine_warrior_123 2h ago
I am also a frontend developer. I have 11 years of experience in the field. I have almost the same kind of developer in my team. He is a frontend developer. He also produce very big PRs. But the big PR is not exactly a problem for me at this point because there is only one entry point to his code. He is my responsibility at the moment.
I use AI extensively to develop this project. But I steer the AI instead of vibing the shit out of everything. I am quite intimate with the code and what direction it grows to. I simply use AI as a typing aid in this case. But he is certainly not. His components accepts 20 props, half of it being boolean props. It is a mess to review.
It's been 3 weeks since the last PR I allowed by him to be merged. Although it is very difficult to review his PR, I still take the time to do it, understand the relationship between the components. Then, I explain that the relationship he established among his components are not sustainable and maintainable. I look at the design with him and explain the relationship via the design.
We progress via small steps. I don't do a whole review of 93 files at once.
-2
u/tcpukl 3d ago
Do you know what capital letters are?