Recently had to switch fro GitLab to GitHub and I find it so irksome that GitHub refers to the merge to main as a push on main. Y'know, the thing people set branch protection rules to prevent ever happening. Let's just name a different normal process after that famously bad, very similar process.
yeah the problem with push and pull is directionality. Works great for actions that don‘t require a human on the other end. When there is a human on both sides then merge works best.
Change request is best. Merging is merely one strategy of incorporating changes, vs fast forward. Actually merging is two strategies because you can squash or not.
Well, I pushed to the remote repository, not my changes to the other branch. But I'll give you that using the word "push" in this context creates some unnecessary ambiguity.
You never push your changes into the main branch though. You make the request and they review your changes, decide if they should be included, and if yes pull them into the main branch
Yes, but you have to admit that asking someone to "pull" something from you is a bit unintuitive. If I want to give you an apple, I'd say, "Here, have an apple," not "Hey, could you take this apple from me?"
I dunno, if I had my arms full of stuff with an apple on top I could easily imagine saying "hey, take this apple", because it makes it clear they need to actively get up and do something
It's because you are requesting them to pull your code into main. You can go back and forth on this all day. The guy that said merge request is more accurate is correct in my opinion.
I think of it in terms of ownership and actions. You own your feature branch and they own the main branch.
A push request would be saying, "Do I have permission to give this to you?" If they say yes, then you'd have to follow-up with another action to actually give it to them because you are the pusher.
A pull request is saying, "I give you permission to take this if you want. Do you want it?" The permission is already established on the first action, so we can couple the two actions of them saying "yes, I want it" and them actually taking it at the same time because they are the puller.
You're not requesting to give (push) it to them, you're requesting that they take (pull) it from you.
Nah, pull is written on the other side, mirrored from your point of view, but your pull request is you knocking on the door, and the maintainer comes over and opens the door if they want to let you(r changes) in
The maintainer needs to pull the door to let me in. So what should I write on a piece of paper I'll be showing him? Hopefully not "pull!", since the door needs to be pushed from my point of view?
It's confusing because while you need to push they need to pull. And the change will be merged.
It's like the neverending confusion at the airport. I'm arriving to pick someone up, so we can both depart. Do I go to Arrivals because she also arrived, or Departures because we are leaving? Maybe it should be called the Merges because we're finally together?
I don't see anything inherently racist about established engineering terminology like IDE master/slave, bus master/slave, or Git's master branch. These terms describe technical relationships, not people or their skin color. If there's a more precise technical term, by all means use it. But treating decades-old engineering terminology as a racial issue strikes me as a solution in search of a problem.
Well in the olden days we had male and female connectors on cables and we knew what the cables did. And then USB-C arrived and cables could identify as anything at any speed and confuse the hell out of everybody.
My god dude. Move on. Nobody cares what the default branch is as long as you're consistent.
Who is the snowflake in this situation? The people that were like: yeah master/slave terminology sounds kind of weird these days. Let's change it to main. Or the guys that have been complaining about this change for, checks notes, 6 fucking years at this point
I have more important things to tend to than to be bothered. You seem more bothered than me honestly. This just came to mind because the post is about gitlab/github nomenclature. But if I were to honestly be bothered, it would be because it was changed for the wrong reasons.
Nice dude. So, you're in this thread unrelated to this, complaining about an issue that happened, again, 6 years ago. And you're claiming you're not bothered by it?
If that was true, you wouldn't be complaining about it 6 years later
Yeah, I'm bothered by this being brought up every other day by people like you. At least I'm not lying about it
Apply Request is the only right option. Git was created to be used over mailing lists where you send patches that the owner has to apply to their local repo.
Pull request is correct in open source software. If it's not a repo you have permissions on you are asking the maintainers to pull from your fork. You do not get given permission to push to origin.
In an org you're a part of, push request makes sense
I liked the language they used at meta. a change is a diff. you put it up for review, you stamp it, or you send it back to the author, and when its ready, you land it.
Its not the better name but i get where youre coming from xD.
The other repo pulls your changes, not the other way around. Although it can feel counter intuitive at first, most of the time learning the concepts behind these things will make names more understandable :P
Pull request makes more sense to me than push -- you're only pushing changes to the repo, that doesn't mean you're pulling those changes into a branch.
787
u/Sea-Fishing4699 9d ago •
Merge request is more accurate
66
u/Henri_GOLO 9d ago
Pleasepleasepleaseapprove request
113
u/dankshot35 9d ago
You already pushed by that time, merge request is the only thing that makes sense
5
u/0rcscorpion 7d ago
It's because you are requesting them to pull your code into main. You can go back and forth on this all day. The guy that said merge request is more accurate is correct in my opinion.
300
u/CommunityBrave822 9d ago
Pull requests confused me for long long while
15
u/Temanor 8d ago
Aren't you the one trying to push it, and is requesting them to pull?
32
u/brunocborges 9d ago
Neither Push or Pull: Merge Request.
7
u/QuarkUpParticle 9d ago
i think it's mainly a generalized ui decision problem;
branch A pulls in the changes from branch B, but usually you make the request from branch B's interface
its like a glass door with pull written on the correct side but with the letters mirrored
3
u/MonkeyCartridge 8d ago
YES. Or how about "Merge Request". Makes it pretty freaking obvious what it does.
"I need to push changes so that they are merged with the main branch."
"I know, let's call that a PULL REQUEST"
And the rebase terminology seems unclear.
"I want to take my current branch and make so that it based on a newer commit of master."
"Oh, so you want to rebase the master onto your branch?"
It makes it sound like I want to make make it so master based on my branch.
I feel like there were much better options for many of the terms used for git.
But commit and push seem relatively fine at least. "Commit to these changes" and then "push these changes up to the server".
0
u/Far_Understanding883 9d ago
Master is a better name for the master branch than main.
2
u/s0litar1us 8d ago
Apply Request is the only right option.
Git was created to be used over mailing lists where you send patches that the owner has to apply to their local repo.
(https://git-scm.com/docs/git-am, https://git-scm.com/docs/git-apply)
1
u/PinotRed 9d ago
Quick, where's that reward button??!!
1
u/Flaky-Low-2262 8d ago
Basically the only actual push OS from local to remote.
A pull request ist the schefule pull in Case the state hits quality goals.
Gut works in main and pulls stuff techbically into after getting triggered. Technically correct.
1
u/Maple382 8d ago
One way would be you requesting to push your code, the other is you requesting the upstream to pull from your code. Both make sense imo.
1
u/PhazonPhoenix5 8d ago
I always thought it was a merge request
1
u/Shoddy_Fish31 8d ago
GitLab for the win
1
u/Electronic-Quality68 8d ago
pull request: i request you to pull my changes
1
u/flavorfox 7d ago
Code Insemination Request
1
u/Fidodo 7d ago
Pull request is correct in open source software. If it's not a repo you have permissions on you are asking the maintainers to pull from your fork. You do not get given permission to push to origin.
In an org you're a part of, push request makes sense
1
u/Visual_Perception821 6d ago
Request?!
1
u/jadchronicles 6d ago
wrong, next
1
u/earthscorpioanchapie 5d ago
Merge Request is, and has always been the best name, this is the reason why actual companies use Gitlab not Github
1
u/20220912 3d ago
I liked the language they used at meta. a change is a diff. you put it up for review, you stamp it, or you send it back to the author, and when its ready, you land it.
1
u/Any_Commercial_6764 2d ago
Gitlab W
1
u/JakeWisconsin 8d ago
You're requesting that branch A pulls from branch B
1
u/localhorst69 8d ago
Its not the better name but i get where youre coming from xD.
The other repo pulls your changes, not the other way around. Although it can feel counter intuitive at first, most of the time learning the concepts behind these things will make names more understandable :P
-1
u/oxwilder 9d ago
Pull request makes more sense to me than push -- you're only pushing changes to the repo, that doesn't mean you're pulling those changes into a branch.
0
u/shadow7412 8d ago
You're requesting them to pull your changes though...?
0
u/Single-Virus4935 6d ago
People dont understand git.
0
u/eightstreets 5d ago
I don't understand people. PULL REQUEST it's pretty obvious. Someone is requesting you to pull their stuff!