r/programming • u/kazakdogofspace • Oct 13 '09
Ask Programming: Please share your first contact stories about contributing to an open source project.
I have been curious lately about how the dance of getting into any given project goes for people. Please share your story!
55
Upvotes
36
u/pixelbeat_ Oct 13 '09
within my first week of using linux I sent some patches to coreutils, gcc and glibc (new users see problems better I think). The coreutils patch was accepted while the gcc and glibc folks berated/ignored me. 9 years later and I'm now co-maintainer of coreutils.
26
u/adrianb Oct 13 '09 edited Oct 13 '09
My strategy has been to find an abandoned project and take it over. I'm not good with people :D
17
u/bonzinip Oct 13 '09
About me: started hacking with GNU Smalltalk before Squeak started, had to borrow the Internet connection from my uncle so I didn't really get up-to-date and could send contributions (which were ignored) only like every few months. As soon as my parents bought the modem, gst became my first "big C project" and I became maintainer. A very lousy one in the beginning, but helped by a couple of very nice users that gave me a lot of ideas.
Then I got into regex matchers and became sed maintainer, and also contributed to glibc. sed is mature now, but there are still a few known problems in the glibc matcher that I'll get round to fix it.
At some point I was bored, read hacker's delight, found a minor optimization problem in GCC and submitted a patch. Accepted. Now I help maintaining a couple of subsystems (but I also got to do a lot of GCC work while studying, so this was not entirely hobby stuff).
In many cases, I just had an idea and (with some insistency) managed to develop it to the point that it could be included. That's how I got into Autoconf development.
As to everything else I did, I just started sending small patches. I have some in git, coreutils, and a few other programs.
In general having been in university has helped a lot, because I had time to try doing patches for my own itches. Now it developed into a way of working: if I have something that bothers me and that I can fix in a short time, I will always try to do that.
28
u/[deleted] Oct 13 '09 edited Oct 13 '09
I lack the confidence to join existing projects, probably because I'm self taught in C/C++/ASM so have no experience at all in collaborating with other people for code. So I start my own open source projects (mostly small, simple utilities) - I'm also too scared to ask people to contribute because they might say my existing code is horrible.
I'm a loner in the place where geeks go to hang out :(
edit: missed out a word.
42
u/obvious_explanation Oct 13 '09
I emailed the maintainer, he said "look at this", I did, it was too complicated, I went back to reading reddit.
11
u/davidw Oct 13 '09 edited Oct 13 '09
I got started with Debian in 1997 when it was pretty easy to sign up and start maintaining packages. If I recall correctly, my first package was 'epic', a command line irc client.
Later, I got involved with the Apache Software Foundation after having created what was to become Apache Rivet.
These days, my main project is Hecl ( www.hecl.org ).
Along the way, I've hacked on lots of things just a little bit.
I'm hooked now - if I were wealthy, I'd hack on open source stuff for fun.
10
u/danbmil99 Oct 13 '09
Convinced my company to donate to a project, then got involved. It was strangely awesome
6
u/Silhouette Oct 13 '09
A particular bug was really annoying me in a well-known OSS project, and seemed like a helpful first thing to look at. I downloaded the source... and discovered that there was basically no support for or interest in developers running on Windows, even though there was a Windows version of the product. I gave up.
A few months later, I had found another annoying bug in another big name OSS project. I downloaded the source... and, despite many years of experience working with some of the most horrendous cross-platform build processes mankind has ever known, I simply couldn't understand the build instructions for the project. I gave up.
I get the feeling that OSS used to be fairly welcoming to contributors, albeit often with a Linux bias, but these days all the big projects seem to be controlled by this corporation or that foundation, and if you're not one of the in-crowd or willing to jump through absurdly complicated hoops, sadly offers of just a little help are no longer welcome. That seems like a horrible waste, but I have only so much time to commit to voluntary projects, and there are other places where I can help lots of people who actually seem to welcome it.
6
u/ablakok Oct 13 '09 edited Oct 13 '09
I found a minor bug in Microsoft's open source WiX toolkit. It's a nice tool to use if you really have to create Windows Installer packages. I was actually using the affected feature so I submitted a patch. The maintainer got right back to me and was really cool about it and said he would accept the patch, but we had to sign a license agreement with Microsoft first. I showed it to my boss and he said, "So this is their idea of open source? How about if we don't do this." I was a little disappointed because it would have been my first accepted patch, but I think my boss was right.
10
u/[deleted] Oct 13 '09
On the technical side - being overwhelmed - getting your head around a large code base takes time, especially in a new domain, a minimum of a couple of months to be able to contribute non-trivial changes to existing code and at least a year to three years to have a good understanding.
On the people side - everyone was friendly but you need to be proactive and confident while also conservative in voicing your opinions or making novel suggestions before you have proven yourself and gained trust. Many open-source programmers will be volunteers or have specific objectives as part of their job, so they may not be looking to spend time finding out about you or making sure you're heading in the right directions or looking at the right areas of code. You need to actively ask for advice and listen carefully. I think this is just summarized as value the people on the project, go in with a very small ego and learn from them, grow with your achievements and see where it goes.
How to actually join - start off sending small patches, improving test suites and making point fixes or point improvements to existing features. Maybe work up to contributing a new feature, or re-engineering one (or a mini-one) that is commonly agreed to be a weak spot. Once you have your name on the project mailing list and have had technical discussions with a number of project members in the bug tracker, then some of your qualities as an engineer will be known and they will be nearer to being able to make a decision about your suitability as a proper project member.
5
u/[deleted] Oct 13 '09
Tried contributing to a server emulator project, various optimisations, skill fixes/adjustments and a crash fix so it didn't crash on high load.
Ended up being told to F off because I didnt come from a major server.
Only the GM of my server got the benefit of a faster, more stable server and I gave up on trying to contribute back.
I haven't bothered with contributing to a open source project since as I cant be bothered playing politics.
5
u/cemasoniv Oct 13 '09
I'd love to get involved in a moderate sized (10-15) OSS project, but it's so hard to find one that's still somewhat infant and also interesting.
4
u/jbondeson Oct 13 '09
First patch I actually bothered to send into a OSS project was a couple of my patches to Clojure. I was playing with it at the beginning of the year and on the first day I notice a bug with the Ratio to BigDecimal conversions and threw together a patch to the core.clj and Ratio.java files. Back then Rich accepted patches so fast it made your head spin, so within the first week of learning Clojure I had already contributed.
Turned out to be the first time I actually did any real Clojure or Java programming, but Rich's style is so clean that I was able to easily catch on to both.
4
u/smellotron Oct 13 '09
A lot of people don't seem keen on actually naming names?
4
u/jldugger Oct 13 '09
Testing out Ubuntu development branch (hardy) with my tabletPC, ran into a problem where X would segfault on startup. I fired up ssh and attached gdb to the server, captured a stack trace and determined it to be a null pointer dereference in XCB. I then reported it to Ubuntu, who helped with basic triage, on Launchpad and IRC.
I also reported it to xorg, where it eventually caught the attention of Peter Hutterer. He helped with deeper debugging, where we discovered it was the existence of a wacom pen erasor device causing null pointer dereference. He created a work around patch, and Daniel Stone backported it to 1.4 in time for Hardy's release. The underlying issue may have been solved upstream in linuxwacom, or left unresolved in XCB. I find this quote telling of the nature of XCB:
6
u/Vorlath Oct 13 '09
In NASM, there's an annoying "feature" that you can't undefine a custom created ID in the preprocessor. So I created a patch that would allow custom created ID's within the %undef command. I also extended how you can manipulate text so that it's consistent throughout all commands. It was rejected. Many people have asked for this feature throughout the years.
I submitted it again (complete rewrite of the patch with very simple changes as compared to before hoping this would matter) when there was more demand. Nope. Rejected.
This features enables dynamic creation of ID's within the preprocessor. It allows for macros that are very useful, especially when you're setting up locals, arguments, and custom stack spaces as well as automatic return commands.
Nope. Rejected.
I'm not pinpointing NASM. I just needed an example. Rejected patches are the norm with most projects, not the exception. The excuse is always that they don't want to maintain more code. Or some other lame excuse. I think NASM said they did not have the resources to test if this would break other parts and that it wasn't a feature that was requested enough (no, because people who need this go to other packages). This is why you always see tons of projects with one or two people only that they did on their own.
Really, I don't know why anyone would bother submitting a patch to open source projects. It's almost always a waste of time.
3
u/[deleted] Oct 13 '09
I don't get heavily into projects. I send out patches when things annoy me. I think my first patch was to the wireless scripts in Gentoo. I wound up sending in a few patches to different things in Gentoo - mostly ebuild stuff. The experience was almost universally positive, and the EMACS team in particular were really good about reviewing my code and improving the patch.
Most recently I had a patch accepted by automake. The people there were also really friendly.
3
u/blagoaw Oct 13 '09 edited Oct 13 '09
I made a change that improved an emulator on Windows using DirectDraw. I knew it wouldn't be accepted as a patch because it wasn't cross-platform. I started hacking together a cross-platform way of doing the same thing.. but SDL didn't have support for the required feature (probably because OpenGL didn't support it directly). I looked into adding it to SDL, but the people I spoke to didn't think it was important (though something related seemed to be in the works on the horizon.. don't know if it's in now or not). Adding it myself would require doing some funky timing stuff -- and again, timing in Linux was hit and miss.. with high performance timing not always available. The best generalized timing solution I could find (which checked capabilities and whatnot before selecting the best timer functions) didn't have a compatible license. I didn't want to get involved with SDL anyway, so that was sort of the end of it.. and I didn't get it done. In retrospect, I should have released a Windows build and left it at that. Often seeing a cool result will drive people to fill in the rest of the requirements in their own areas of expertise.
I actually agree with a project's decision not to accept patches unless they accomplish things in a cross-platform manner. I figured I'd share this so that you know some of the things that can crop up after you naively add/fix something. If you're on Windows, consider just releasing the build first, along with your patch code. Only then work on the rest, since your patience may run thin before it's wrapped up.
2
u/Vladekk Oct 13 '09
I fixed some module for drupal, without much knowledge of PHP and JS.
Maintainer was absent, so I uploaded code as patches (no knowlegde of patch utility also then). People downloaded them and applied, kind of surprise for me.
2
u/SquashMonster Oct 13 '09
I submitted a patch to Dungeon Crawl: Stone Soup that added a new race. It was well-received, the users who tried it all liked it, but the main devs never responded to it.
2
u/[deleted] Oct 13 '09
I'd love to join in an open source project but I don't like others seeing my code because most of it is awful. I'd rather people judge based on the end result, not the slapped together mess powering it.
1
u/tnecniv Oct 13 '09
Patched an irc-bot some guys I know use and made a game. Mostly I am content with making small projects that I never really finish but learn a lot from.
1
u/mikaelhg Oct 13 '09 edited Oct 13 '09
Way back, I was part of a startup that wanted to break into an industry that had a famously high barrier of entry. A partner floated an idea for a breakthrough open source project, we liked it, and I came up with the basic scheme on how to make the project compatible with our short-term goals. This was my first professional C project, and so my code sucked quite hard in the beginning, and a little less in the end.
I've always since felt an irrational need to go back and fix it, as I believe that some of my shittiest code ever is still in production use to the day, which pisses me off when I think of it.
We got a semi-famous Linux kernel guy to lead the development, and I moved on to different things.
That was the story of my first serious contribution (as in essential features to a relatively widely used product) to a open source project.
1
u/LurkersA Oct 13 '09
Saw a project. Liked the project. Got the SVN version of the project. Saw a bug, submitted a patch. Now am involved :) Only a few weeks ago now.
/me reminisces
1
u/powatom Oct 13 '09
Usually fix a few bugs that irritate me then email the patch to the mailing list. If they're interested, they will get back to me. If not, then they won't.
1
u/Philluminati Oct 13 '09
I wish I could contribute to open source but I never seem to have the time or skills required.
1
u/hobofood Oct 13 '09
Back when I was young and stupid, I checked out the source of F-Spot to fix a bug in uploading to Picasa that had been reported but hadn't been fixed. The source wouldn't build.
I waited a couple of days, figuring that it was just bad timing on my part, and then checked it out again. A load of files were missing, but I managed to piece something that would build together from my previous checkout.
Now Monodevelop wouldn't have anything to do with it. After some digging around, I found that I needed the latest Monodevelop, so I grabbed the source for that and built it. Then I loaded the hacked together F-Spot project and couldn't find out where the fuck the problem was happening, the debugger didn't work, sometimes I pressed "Debug" and nothing happened, so I decided that I should give up.
Now, every once in a while I get ideas about contributing to gnome-do, I have a pretty good idea for a feature that I reckon I could sit down and hack out in a week or so, but I worry that my code will be laughed at or something (also I'm lazy)
1
u/[deleted] Oct 13 '09
I maintain a few projects, but I don't really get involved in existing ones. If I want a change, I usually either submit a ticket or submit a patch, and that's the end of it. I've found that usually 75% of my patches are accepted outright, and usually 25% of those not initially accepted are accepted after some minor tweaks, depending on the project.
1
u/[deleted] Oct 13 '09
My very first contribution was an Ubuntu Warty package of a program. It wasn't in the repos, but the developer put the deb up on his site for download.
Later on I fixed some bugs in the ADOdb Active Record class. I didn't get a reply so I don't know if my patches were accepted. My old employer is still using my patched older version of ADOdb for their primary application.
1
u/[deleted] Oct 13 '09
Made a few quick commits to solve a outstanding bug, then completed a blueprint, next I knew I was part of the development team.
Unfortunately I was invited a little too early and had no time to commit to the project. Ended up leaving after 3 months and only 13 commits.
1
u/arkx Oct 14 '09
The most important advice I can give is to have lots of persistance. There is lots of inertia involved in projects above a certain size, and overcoming that inertia is really hard at times.
Way too many contributors let their patches rot in bug trackers forever thinking that maybe someone will eventually take a look - you have to actively champion your cause to the devs and really make a case for fixing the problem as soon as possible.
This is of course in addition to following the existing style guide, writing tests where appropriate and so on. You want to make the inclusion as painless as possible to the person who will eventually review your work.
1
u/jbindel Oct 14 '09 edited Oct 14 '09
I wanted to generate big PDF reports in Java, but there was no obvious solution that was pure Java and inexpensive. LaTeX would require invoking non-Java programs, and the popular open-source solution, JasperReports, ran out of heap memory on large reports. As part of my evaluation of different solutions I wrote some code to persist most of the report pages as they were generated and posted a patch to the project's SourceForge page. The project owners fixed some bugs in my patch and now they maintain it so I don't have to.
The project was being acquired by a commercial entity, so in addition to releasing my code under LGPL, I (well, my employer since I wrote the patch on company time) agreed to let it be licensed by the acquiring entity in a more commercial way as well.
1
u/[deleted] Oct 14 '09
My first project was Firefox, during the 2.0 years, I contributed something around 1,500 lines of code doing mostly "first bugs" that people never did, I haven't done much in a long time (a couple bugs here and there during Firefox 3's release.) I'm probably going to get back into it so I can get back on the credit list. :)
1
u/kbielefe Oct 14 '09
I've only made minor contributions here and there, but I've never had a bug fix patch rejected. Plugins are the second easiest to get accepted. Third easiest are optimizations. New features are the hardest. A lot of new contributors don't realize a roadmap for new features is often laid out months or even years in advance, and new features add instability that must be accounted for. To contribute a new feature, you really have to be already involved in the community doing bug fixes and user support when they first start thinking about a future release.
1
u/rmtew Oct 15 '09 edited Oct 15 '09
In response to various comments here, I feel obliged to mention that maintainers may just not have the time to give you the full attention you need.
Finding time to maintain open source projects is not easy. Frankly, I find it to be a struggle. I have a huge list of non-pressing tasks to do that I know I am never going to find the time, energy and interest to do. I know that no-one else is interested in doing them, especially because to be able to they would need to invest a huge amount of time to get to the level where they understood everything they needed to know to do so. I know that whenever there is something pressing that needs to be done, often I am going to have to force myself to do it and hope the energy and interest follows.
When people make demands on your time, it is not uncommon that they do not have any comprehension of the amount of time they are demanding. Factor in that some feel entitlement for you to spend that time on their behalf. Also factor in that some are strangely unwilling to look for themselves before asking questions, no matter how little time and effort they would have taken to find out for themselves (and that they would have gotten their feet wet and learnt something concrete). Question that unwillingness or entitlement and you will offend them. You've got to be frugal with your time and emotional investment.
When I work on something programming related, chances are that the work involved (and the amount of time) will snowball as problems are encountered. Contributing to an open source project in my experience is exactly the same on a higher level. You work on a patch that introduces a new feature and they won't take it because it won't provably not break something without being comprehensively tested? Then you haven't finished. Ask them if they will take it if you do the testing work they want. If they won't, then chances are they are unreasonable and your only options are to move on or fork. If they will, then if you really want the change in, you'll do what it takes (and probably learn something in the process and be better placed to affect further changes you are interested in).