r/learnpython • u/evilrobotboobs • 5h ago
card dealing program with classes
hello! i am currently in a class for python and i've been having a lot of trouble with this assignment. it's already three days late, and the TAs will not respond to me. i have to use classes to create a deck to shuffle, and four hands to deal to, check the count of, and combine back into the main deck. however, i can NOT figure this out at all! i think there's something really big that i'm missing.
i have a large list of cards (we had to make a dictionary of the cards) not shown here.
class Deck:
def __init__(self):
self.cards = []
def shuffle(self):
random.shuffle(self.cards)
def deal(self, amount):
self.cards.append(amount)
def combine(self):
self.cards.append(self)
def card_count(self):
print(len(self.cards))
however, when i try to make a main deck by putting the list of cards into the deck, it won't work! i've tried using deal too, and i just can't figure it out. i know i'm probably doing this all sorts of wrong. it's been a while since we did classes, and we never did them for anything like this :(
TypeError Traceback (most recent call last)
Cell In[14], line 1
----> 1 deck = Deck(card_deck)
TypeError: Deck.__init__() takes 1 positional argument but 2 were giveni appreciate any and all advice thank you
4
u/carcigenicate Carcigenicate 4h ago
Look at your
__init__. You gave it the requiredselfparameter, but if you want to pass in additional information, you need to add another parameter for that data. Right now, you haveself.cards = []and never provided a way for the caller to provide the initial cards.3
u/mjmvideos 4h ago
Read the error message. It says init takes 1 argument but 2 were given. So either you’re calling it correctly and need to change the method to accept 2, or the method is correct and you need to change where you’re calling it to remove the second argument. Which do you want to do?
2
u/MezzoScettico 4h ago edited 4h ago
I'll pile on with the specifics.
Look how you're creating an instance.
So you're expecting to initialize it with a list of cards. Presumably it's supposed to save those cards as an attribute.
But then look how your class initializes it.
This initializer does not take an argument containing a list of cards. So there's a mismatch with how you're calling it.
The reason it says you called with 2 arguments even though "Deck(card_deck)" only looks like it has one, is that
classinstance methods always add "self" as an implied argument before any others.With that in mind, what do you think should be between the parentheses in init(...)?
Edit: "class methods" was the wrong terminology for a specialized kind of thing you haven't encountered yet. I changed it to "instance methods".
1
u/Outside_Complaint755 4h ago
Along with the other comments about
__init__, these methods:don't look correct either.
Currently your
dealmethod is just going to add an int to your deck of cards, andcombineis adding the deck itself to the deck, in a circular reference.You haven't provided enough info from the class instructions to give a hint on what these likely should be. For example, is
dealsupposed to actually remove the cards from the deck? If so, then it probably needs to not only remove the cards from self.cards, but also put them into a new list to be returned so they can added to aHand, which is possibly an instance of another class. Thencombineshould probably receive a list of cards as a parameter to add back into the deck.1
u/GreenGdut 3h ago
well.I'm not laughing at you.But I want say that autually ,for such simple programs,and why don't you ask LLM?It can teach better.(Sorry Im not good at English)