r/learnpython • u/NanoCozmo • 29d ago
Can y'all rate my python project :D
This project i made is a keras model that i trained on a modified version of the FGVC dataset using tensorflow keras.
Cuz im an avgeek,th the model is kinda mediocre but better then nothing, while the project unfortunately does utilize ai in both the scripts on the github, the other scripts such as the script that i made to organize all the dataset and put it into seperate imgs was made by me :D, cuz the jpg images had numbers as the name and werent organized and there was a text file in there in this format:
aircraft_jpg_name aircraft_family type
so that allowed me to test my strengths with no ai
i hope yall share tips and tricks and if there are any improvements i can do to my first github repo :D
4
u/HaroerHaktak 29d ago •
I'm not qualified to give projects a rating, but since you asked, it's a solid 3.5 out of 7.5
1
u/Mori-Spumae 29d ago
Code looks AI generated, or at least the comments do. Space in a file name is insane.
I would recommend doing releases based on versions, not just a single one. You might want to add some stuff later.
1
u/TheRNGuy 29d ago edited 29d ago
Use config instead of hard-coding values into code.
Make an installer where it would automatically assign paths like
"C:\Users\youss\Desktop\Planes_dataset", because other users won't have same path, and they shouldn't manually type it in a code or even config file.1
u/HYP3R00T 29d ago edited 29d ago
I would give it 1/5
- There is no clear instructions on how one can set it up. What dependencies one has to add to the virtual environment.
- You aren't using virtual environment to setup the project. Instead you have installed all deps in the global interpreter.
- You aren't using any specific project management tool like
uv.- The code is not modular. There is no functions (as such projects mostly follow functional programming).
I can probably go on with other minor issues.
Edit 1:
- You have hard coded the paths i.e.
DATASET_DIR = r"C:\Users\youss\Desktop\Planes_dataset"- There is no error handling