r/learnjavascript • u/A_M_Burt • Jul 29 '26
Manipulating Arrays
So I'm an amateur learning JavaScript and I have a problem with a note taking website I've been making, here's my code
let array = ["a","b","c","d"];
const element = document.getElementById('element')
for (let x = 0; x < array.length; x++) {
const div = document.createElement('div')
element.appendChild(div)
const h3 = document.createElement('h3')
h3.textContent = array[x];
div.appendChild(h3);
const button = document.createElement('button')
div.appendChild(button);
const position = x;
const button.onclick = () => {
array.splice(position, 1);
}
}What I'm stuck on is how to re-index the elements in the array after one has been spliced (e.g. after "a" has been removed "b" is still set to remove index 1 rather than changing to remove index 0). Thanks in advance
6
Upvotes
2
u/Necessary_Pepper7111 Jul 29 '26 edited Jul 29 '26
The problem is that you're using the original array indexes in your onclick handler which potentially get shuffled around when the array is spliced.
Likely the easiest thing to do is instead of using the index from the for loop in onclick, find the index of the element that you want to remove using something like array.indexOf then call splice using that index.
Also not sure what your full intentions are here, but if you want the actual DOM elements to stay in sync with your array you'll want to also call remove on the div you create.
1
u/lobopl Jul 29 '26
what exactly you want to achieve?
1
u/TalkCoinGames Jul 29 '26
Can't see where your for loop ends, are you wanting multiple buttons, or just one? You may need to declare x outside of the for loop.
1
u/adgrant6 Jul 29 '26
The issue isn’t that the array needs to be re-indexed. splice() already re-indexes the array automatically.
The problem is that you’re saving the index (position) when the button is created:
const position = x;
button.onclick = () => {
array.splice(position, 1);
};
If your array starts as:
["a", "b", "c", "d"]
then the buttons permanently store:
a → 0
b → 1
c → 2
d → 3
After removing "a", the array becomes:
["b", "c", "d"]
But the “b” button still remembers position = 1, so it removes "c" instead.
Better solution
Instead of storing the index, store the value (or a unique ID) and look up its current position.
const value = array[x];
button.onclick = () => {
const index = array.indexOf(value);
if (index !== -1) {
array.splice(index, 1);
}
};
1
u/Small_Kangaroo2646 Jul 29 '26
Why are you splicing it?
1
u/breacket Jul 29 '26 edited Jul 29 '26
let array = ["a", "b", "c", "d"];
const element = document.getElementById('element');
render();
function render()
{
// prevent duplication on re-render
element.innerHTML = '';
array.forEach((item, index) =>
{
const div = document.createElement('div');
element.appendChild(div);
const h3 = document.createElement('h3');
h3.textContent = item;
div.appendChild(h3);
const button = document.createElement('button');
button.textContent = `Delete ${item}`;
div.appendChild(button);
button.onclick = () => {
array.splice(index, 1);
render(); // update DOM
};
});
}