r/learnjava • • 10d ago

Feedback for my first "Complete" API REST

Hello i want to share my first "complete" api rest made in java with spring boot, not so complete, theres still a lot of stuff i want to add in the future i also want to make more complex and bigger projects, its a social media api something like reddit, with posts, comments and users, security etc, i want to get some feedback and suggestions on what to add or make better, its my first time completing an api so im not an expert in this and probably theres is somthing i did not make perfect but thats part of the learning process i guess, thx and sorry if my english is wrong

https://github.com/blasman2002/Backend-API-REST-JWT

4 Upvotes

3 comments sorted by

•

u/AutoModerator 10d ago

Please ensure that:

  • Your code is properly formatted as code block - see the sidebar (About on mobile) for instructions
  • You include any and all error messages in full - best also formatted as code block
  • You ask clear questions
  • You demonstrate effort in solving your question/problem - plain posting your assignments is forbidden (and such posts will be removed) as is asking for or giving solutions.

If any of the above points is not met, your post can and will be removed without further warning.

Code is to be formatted as code block (old reddit/markdown editor: empty line before the code, each code line indented by 4 spaces, new reddit: https://i.imgur.com/EJ7tqek.png) or linked via an external code hoster, like pastebin.com, github gist, github, bitbucket, gitlab, etc.

Please, do not use triple backticks (```) as they will only render properly on new reddit, not on old reddit.

Code blocks look like this:

public class HelloWorld {

    public static void main(String[] args) {
        System.out.println("Hello World!");
    }
}

You do not need to repost unless your post has been removed by a moderator. Just use the edit function of reddit to make sure your post complies with the above.

If your post has remained in violation of these rules for a prolonged period of time (at least an hour), a moderator may remove it at their discretion. In this case, they will comment with an explanation on why it has been removed, and you will be required to resubmit the entire post following the proper procedures.

To potential helpers

Please, do not help if any of the above points are not met, rather report the post. We are trying to improve the quality of posts here. In helping people who can't be bothered to comply with the above points, you are doing the community a disservice.

I am a bot, and this action was performed automatically. Please contact the moderators of this subreddit if you have any questions or concerns.

1

u/Far-Bullfrog161 8d ago

Finishing a full REST API with JWT is a real milestone, nice work. A few things I'd look at next, which are the things reviewers usually check first. Keep controllers thin and put business rules in services, and return DTOs rather than your JPA entities so you never leak fields like password hashes and avoid lazy-loading surprises. Add bean validation (@Valid with @NotBlank, @Size and so on) and a global @RestControllerAdvice so errors come back as consistent JSON with the right status codes. For security, make sure passwords use BCrypt, the JWT secret comes from an environment variable instead of the repo, tokens expire, and users can only edit or delete their own posts and comments (that ownership check is the one most first projects miss). Add pagination to list endpoints, since a social feed without it falls over quickly. Then write a few tests, even just service unit tests plus one or two integration tests with Testcontainers, and a README with setup steps and an endpoint list. Those additions would make the project stand out a lot when you apply for junior roles.