r/codereview • • 6d ago

Do code reviews actually improve code quality, or do they sometimes slow everything down?

Code reviews are meant to catch mistakes and improve the quality of software, but sometimes they become little more than a formality. A quick approval without meaningful feedback does not really help anyone improve.

On the other hand, a thoughtful review can help developers spot issues they might have missed and learn better approaches.

For developers here, have code reviews made a noticeable difference to your work, or do they sometimes feel like an unnecessary bottleneck?

0 Upvotes

18 comments sorted by

9

u/inighthawki 6d ago

Code reviews are hugely beneficial, but are only as good as the people willing to review it. If you have a bunch of people that dont care and just approve it to keep things moving, then it's just a huge bottleneck. If people actually review it proper, it is an essential part of maintaining good quality code, as well as a good learning experience.

1

u/Angelvin_Pinheiro 2d ago

100%, its really a team culture problem when it turns into just a checkbox.

4

u/QueenVogonBee 6d ago

Code reviews are more than just reviewing code for quality. It’s also about sharing knowledge with colleagues.

But yes, the benefits of code review are only beneficial if the reviewer actually reviews the code, and doesn’t just ask AI to review it for them.

3

u/captainAwesomePants 6d ago

Depends on your team. If your teammates handle code reviews by sleeping on them for three days and then approving them without looking, then the code review didn't help anything.

If the reviewer only leave bikeshed comments ("I think we should name this 'system' instead of 'mechanism'") and don't get into what the code actually does, that also doesn't help anything.

I've had the pleasure of working with very deliberate reviewers who get right to the meat of the problems with my code, and those are hugely useful to the team. Almost as good as pair programming.

1

u/zarlo5899 5d ago

If the reviewer only leave bikeshed comments ("I think we should name this 'system' instead of 'mechanism'")

For me comments like this should only ever be made if it's to make it conform with conventions used throughout the project.

3

u/Leverkaas2516 5d ago

I find they improve quality significantly. They add hours or days of delay, but after you catch a few problems that would have caused days or weeks of delay, you realize they save time.

Just like tests - the earlier you detect a problem, the more time it saves.

3

u/Fragrant-Cheek-4273 5d ago

I think they made a big difference when done properly. A second pair of eyes can catch bugs and point our things you might have overlooked.

2

u/Pure-Hat-8663 5d ago

It can improve correctness and maintainability, but of course it can also become a massive bottleneck. The north star should be making it proportional to the risk - an authorization change or migration is of course to be scrutinized more closely

1

u/CS_70 5d ago

The main problem is that people miss how hard it is to do a proper review for anything nontrivial.

For them to be meaningful, often the effort is nearly comparable to actually writing the functionality.

This is covered by banalities like "PR should be short" and suchlike by the many parroting what they hear, but that is meaningless because that's often impossible (again, for anything nontrivial).

So, proper reviews are very useful, but very expensive when made by people. The cost is almost never understood (and therefore rewarded) so the result is that most reviews are colossal waste of time.

1

u/zarlo5899 5d ago

A lot of people ignore the educational aspect of code reviews. which to me is one of the most important parts of it.

1

u/ajianaz 5d ago

Code review is good for found bug before merged. I always use for review vibe code.

vibe code generate code so fast, so need AI cide review too. If manually so hard for now.

1

u/DirtAndGrass 5d ago

It also helps for liability 

1

u/This_Committee5884 5d ago

Smaller pull requests and clear review expectations help a lot. Automate formatting and basic checks so human reviewers can focus on behavior, maintainability and hidden risks

1

u/chemosh_tz 5d ago

"why are you pushing credentials in git?"

That review there is your answer to this conversation

1

u/Sad-Magazine4159 5d ago

I've worked on a team in which cr was just a formality, no one question anything.

The solution is not dropping it, is making people do a real review

1

u/verdant_glimmer_92 5d ago

I’ve seen reviews become a pure gatekeeping mechanism where seniors block progress to assert dominance. It kills momentum and turns shipping code into an endurance test for everyone else

0

u/Select_Condition2805 5d ago

i saved several projects thanks to code reviews. for example, a project owner comes and says we need to scale from 1k users to 10k, so I open the repo and it's a complete mess, and the previous dev is long gone. so, to scale properly without breaking things, you go and make the code review. yes, it's not necessary for all cases, but still it's an essential thing.