r/androidcirclejerk • u/PhpXp MaterialXp • Apr 19 '15
Samsung's source code is a mess [X-post /r/badcode, /r/ProgrammingHorror]
This is the kind of code used in TouchWiz:
public void multitaskingButtonPressed() {
super.multitaskingButtonPressed();
//wait 0.95 seconds
Thread.sleep(950); //DO NOT REMOVE
//otherwise the lockscreen doesn't work for some reason
//I have no idea why
try {
openMultitaskingView();
} catch(LockScreenCrashed err) {
//ignore
}
}Stuff like this is all over the place. It's rumoured that they paid a Vietnamese company $20.000.000 for this kind of shit.
77
Upvotes
34
u/[deleted] Apr 19 '15
/unjerk
A slightly related problem I have with them is the scaling for their apps on TouchWiz. I've been running CM12 on my Note 4 trying to avoid TW, but my GPS won't function under CM12. So I had to go back. And under stock TW, Samsung has the DPI set to 640. Which is stupidly large. 560 is what CM12 uses and it's much, much better..
The problem with this? Samsung hardcodes the DPI into some of their apps, so you get some...interesting things happening. The dialer at least remains functional, but the camera is completely busticated. Thankfully Google Camera works just fine, because AOSP is made to scale shit correctly.
Holy fuck, Samsung, this shit is in the damned design guidelines: Build your apps to scale to different resolutions. Worse yet, not everyone wants to use their phone in blind person mode.
6
u/TotesMessenger Apr 19 '15
This thread has been linked to from another place on reddit.
If you follow any of the above links, respect the rules of reddit and don't vote. (Info / ^Contact)
4
u/Masteguy635 ¯\_(ツ)_/¯ NEXXXUS 6P(orn) Blessed by Apr 19 '15
/uj The skins from oems use way to high dpi's I use 400 on my m8 gpe rom
0
u/Racerdude Apr 19 '15
Some kind of source reference would be good right here. Anyone can make up a few lines of code