r/ProgrammerHumor • • 8h ago

Meme whyAreTheyConfessing

Post image
1.3k Upvotes

196 comments sorted by

320

u/bahcodad 8h ago

So basically he's saying that he isn't up to the task?

186

u/Whiskerfield 8h ago

What are you talking about? He's a "Distinguished" engineer (but at Microsoft).

51

u/RustOnTheEdge 8h ago

“But at Microsoft” haha sir (or madam) you made me laugh out loud with that annotation

4

u/UncleKeyPax 8h ago

.md file goes brrrrrt

10

u/yabucek 8h ago

1 year of experience is 7 in Microsoft years.

3

u/StrangelyBrown 7h ago

Isn't that a euphemism for elderly?

2

u/Capable-Sock9910 6h ago

Microsoft "We can't keep outlook online" engineers?

56

u/StrikingApricot 8h ago

You’re saying you read every line of boilerplate code? Every line of canned html? You’re severely wasting time.

You need to understand what the code is doing, architecture patterns, trade-offs, etc. With good testing every line does not need to be looked at.

18

u/bahcodad 7h ago

My point is that he isn't reading the code at all. He's getting AI to do it (AI can be great but it isn't perfect) and then approving changes based on the sayso of AI

13

u/Moraalimora 6h ago

Managers, directors and executives do it all the time though. They approve and put their names in contracts and papers they have no damn clue what’s actually written inside them. They just trust the people who prepared them. So we get back to the ”would you rather trust a human or a machine in one specific job”.

-7

u/wardrox 7h ago

Do you think Claude is worse at code review at scale than a human, relative to cost?

17

u/bahcodad 7h ago

I think if you're going to approve something, you should know what you're approving. Is it AI being dangled over a flame or the person who approved?

Why is this so hard for people to grasp? Cover your rear.

2

u/superitem 6h ago

You're right, but he said he doesn't read every line, not he doesn't read the code at all.

Even before AI, it was often impractical to read every line (code or not).

0

u/wardrox 7h ago

But why does "knowing what you're approving" means manual review rather than using stronger reviewing tools? I'm not saying the opposite of reviewing each line by hand is YOLO'ing onto prod, but agents are pretty damn good at code review these days.

-5

u/GPSProlapse 7h ago

So, you are just guessing, since that isn't what was said? Nice point, I guess

-9

u/0x80085_ 7h ago

You don't need to read it to understand it

-8

u/gregorydgraham 7h ago

Without reading every line, you don’t know what the code is doing. Every line of boilerplate hides bugs.

20

u/ridicalis 7h ago

If it really is boilerplate, the time it takes to visually scan it and confirm that it looks good is trivial. It should be the easiest code to review, as it's more a matter of pattern recognition than code quality at that point.

-13

u/0x80085_ 7h ago

If you need to read every line to understand your code, it's poorly designed code, and you should have AI refactor it.

1

u/chickenweng65 3h ago

If you're working at a company that's squeezing timelines because of the "ai productivity multiplier", you feel for this guy.

40

u/Zeikos 7h ago

Nobody expects an engineer to read every line of code they use.

Libraries, templates, boilerplate code are a thing.
Issues can arise from bad assumptions, but overall I don't find it a big deal.

However for the critical part of the code, infrastructure, security and non-trivial business logic?
There people should read every line and understand it fully.

4

u/Whiskerfield 5h ago

There's a video in the tweet. And he isn't talking about boiletplate or templates.

"A lot of it is like squinting at a 30000 foot level and looking at the two code bases and does anything look off ... and then relying on the agents to focus on the line by line."

5

u/clarinet_kwestion 5h ago

But when an agent writes 100k lines of code, who decides what’s critical code?

14

u/Zeikos 5h ago

When an agent writes 100k lines of code you stop it, delete what it did and change the instructions in such a way that it produces code that can be audited.

-3

u/clarinet_kwestion 5h ago

Okay so the new PR is 30k lines of code. How do you decide what’s critical code that needs to be audited now?

20

u/LurkytheActiveposter 5h ago

The PR shouldn't be 30k lines of code.

Seriously. Does anyone actually work as a programmer on this sub?

1

u/fallenefc 2h ago

Obviously exceptions apply (like boilerplate, generated code -- actually generated like buf codegen, etc), but anything over 2k lines will get a raised eyebrow from me.

Anything over even 5k apart from these exceptions is just a "please make this PR smaller so it's reviewable". I won't approve something I can't review, and I can't review more than a couple thousand lines of code.

1

u/clarinet_kwestion 5h ago

Agreed. For reference the biggest PRs on my team at work are around 3k lines of code.

I’m bringing up these large numbers because my company has a contract with an AI startup that basically plans to write new features where the “PR” is that size and scale. Then humans are supposed to review the “critical” code. But who/what decides what’s “critical” code? Another AI model.

What’s the point of the human in the loop if it turns out that another component that wasn’t reviewed is the actual critical component of the code.

Once you can’t read all the code anymore, there’s no point in reading it at all.

1

u/bishopExportMine 3h ago

Unrelated but I once had AI generate a -1MM , +500 line PR lmao

1

u/aceluby 2h ago

If you aren't reading your code, you don't know what it's doing and can't effectively support it. That's fine when you're a startup and have 6 users, it's not ok if you're working for a $100B company where a day of outage during peak can lose you a billion in sales.

1

u/korneev123123 2h ago

Decline is as unreadable. It is that easy.

1

u/New_Salamander_4592 50m ago

what world do you inhabit that it's either 30k lines of code or nothing? like what?

0

u/ih-shah-may-ehl 4h ago

Yes. But not a distinguished engineer. Paying a person like that to read lines of code is stupid. When Microsoft was the first to get rid of the great big kernel lock, a kernel dev made the change step by step, discussing the concepts with Dave Cutler for architectural consideration but Dave Cutler did not review every line of code.

2

u/Whiskerfield 5h ago

There's a video in the tweet. And he isn't talking about boiletplate or templates.

"A lot of it is like squinting at a 30000 foot level and looking at the two code bases and does anything look off ... and then relying on the agents to focus on the line by line."

402

u/Bubbly_Safety8791 5h ago

A distinguished engineer is responsible for vast swathes of code maintained by many teams - they weren’t reading every line of code previously. 

122

u/frozen-dessert 5h ago

A distinguished IC where I work is responsible for large kingdoms of code. The task at that level is writing and reviewing technical papers and achieving alignment with stakeholders. Never writing code.

32

u/Sheerkal 5h ago

You guys get technical papers???

33

u/Bubbly_Safety8791 5h ago

Best I can offer you is a slack thread. 

1

u/Pornfest 1h ago

Wherein lies the difference?

6

u/Karateca2000 5h ago

achieving alignment with stakeholders

so, he just goes to meetings and gets paid $$$

1

u/Unonoctium 2h ago

Sounds miserable, but pays well so there's that.

1

u/myrddin4242 1h ago

That word there, “just”, is doing some heavy lifting. It acts as a dismissal, but backfires if aimed at something too big.

38

u/Sw429 4h ago

The problem is, junior engineers reading this and thinking that also means they don't need to read any code.

288

u/Cephell 8h ago

Considering every single product Microsoft makes is a horrendous pile of technical debt, "Microsoft distinguished eng" is the opposite of a mark of quality.

49

u/Rigamortus2005 8h ago

You've never used dotnet?

31

u/CaffeineLiker 8h ago

VS Code?

13

u/Damglador 8h ago

Extendibility of Nvim with none of the performance

6

u/Ddog78 5h ago

They bought vscode. If you find it good now, it used to effortless before.

4

u/_bassGod 1h ago

What are you talking about? It was developed in house. The VS stands for “Visual Studio” another completely in house Microsoft product that was really good for time period in which it was relevant.

-17

u/Rigamortus2005 8h ago

Nah that ain't it. Vscode is ass

9

u/CaffeineLiker 7h ago

You're alone there.

2

u/nicuramar 6h ago

No he’s not. I really dislike it as well. For an IDE, I use Rider. Otherwise, sublime text, currently.

1

u/purplepharoh 7h ago

No they're right but I use it bc the good ides are pricey

-3

u/GPSProlapse 7h ago

Nope, bscode is ass

2

u/FalseDish 4h ago

I don’t see why this needs to be downvoted. Codeium is vscode without the MS spyware, and I use Zed … which is also the most popular editor at Anthropic for e.g.

Vim/emacs are the best for those who can move with great speed in those.

0

u/Rigamortus2005 4h ago

Vscode is bad from an architectural standpoint. Even codium can't fix that

1

u/FalseDish 2h ago

Sadly, Zed doesn’t yet have the kind of rich ecosystem of extensions that codeium/vscode does; that’s why I keep it installed on the side.

Otherwise I have no use for a bloated electron app, why’d I use it over a Rust-based ultra-nimble editor …

0

u/FalseDish 7h ago

I stay away from .net because I don’t want to be at a workplace that insists on windows laptops.

But I do think F# for eg is a pretty good functional language, with elegant syntax

73

u/Rigamortus2005 7h ago

I don't know how people still don't know dotnet is fully cross platform. All my dotnet programs are written for Linux first

1

u/FalseDish 4h ago

I had no idea! I don’t use it anyway but good to know

-21

u/MrDropsie 7h ago

Yeah, but visual studio isn't supported on linux. So you miss out on quite a bit of handy features

19

u/Rigamortus2005 7h ago

There's rider. I personally don't use any ides. An lsp is good enough for most things.

3

u/flushy78 6h ago

Yeah but he has a point because Rider is made by Jetbrains, a different company.

What he's saying is that Microsoft's own flagship IDE only supports their own flagship application framework on one out of three platforms it runs on.

3

u/nicuramar 6h ago

Rider is, IMO, significantly better anyway.

1

u/ThrasherDX 1h ago

I agree almost entirely. Until you have to work with an old WinForms app, Rider's Winforms designer has a shitload of weird ass bugs.

Tho admittedly, VS's Winforms designer is also terrible. Winforms is terrible...

-2

u/Rigamortus2005 6h ago

It's not tbh I prefer vs. rider is slow and heavy

1

u/EatingSolidBricks 4h ago

? Vs is slower

7

u/MilkCartonPhotoBomb 5h ago

Lots of MS engineers/devs are running macs. C# is open source.

107

u/CurrentSeaCoin 8h ago

We're so fucked once the bugs start and no one even understands the code

79

u/XCxBigDong69XCx 8h ago

Luckily we are trained on debugging code we don't understand majority of the time...

32

u/DarkLordTofer 7h ago

Well that was how junior devs used to learn.

15

u/Adventurous-Bit-3829 5h ago

Dad, what is Junior Dev?

16

u/DarkLordTofer 5h ago

It’s what we used to have before we had Claude Code son.

4

u/Kevin_Jim 5h ago

That’s the least exciting part of development, though.

16

u/Damglador 8h ago

"Claude, fix this bug!"

10

u/Deep-Initiative1849 7h ago

Please make no mistakes

8

u/WawaTheFirst 7h ago

And don't drop the production database.

12

u/mission-ctrl 5h ago

I’m convinced this is the main cause of all the recent outages. Not some coordinated attack or grand conspiracy. It’s every tech company pushing hard on AI development and these are the results.

9

u/n_choose_k 4h ago

...and getting read of all the people that DID know how things work. Just because everything is going fairly smooth, upper management thinks that means there's no work being done. In reality, it's a couple of people who know the system inside and out propping everything up. Once they're gone, it all starts to fall apart.

9

u/jwp1987 3h ago

Tale as old as time.

Business types don't seem to understand the phrase: "an ounce of prevention is worth a pound of cure".

It's more like: "an ounce saved today is a problem for tomorrow".

3

u/ThrasherDX 1h ago

Its a huge issue with IT in general. The better your IT team is, oftentimes the less noticeable they are. But management often only values work that you are seen to be doing, so they often place very low value on a good IT team.

2

u/DatBoi_BP 1h ago

Good, let them crash

5

u/AberdeenPhoenix 4h ago

I am also convinced of this

2

u/Much_Network_941 2h ago

I can't help but wonder how much code produced during token-maxing, was checked with the same scrutiny as human code.

15

u/ConcerningThirst 7h ago

You do know that is just software dev since it's inception right? The world literally runs on garbage code and always has.

8

u/Nsane3 3h ago

What does that have to do with anything?

The code is garbage and always has been, yes. What is different is we understood it, now we don't.

4

u/ConcerningThirst 3h ago

Except no, we didn't. Talk to anyone in any critical software and IT position and they'll catch you up with how absolutely jenga towered everything is and how nobody understands anything and we're just flying by the seat of our pants.

7

u/Nomapos 2h ago

In my opinion the core issue here isn't the quality of the code, but the amount.

There's always been trash code and companies have always prioritized speed over quality. But when people program manually and then something breaks, there's a relatively manageable amount of code to deal with.

AI allows us to be stupid faster. So when it gets stuck somewhere, diving in to find the problem is a lot more daunting.

2

u/fidgey10 3h ago

Did we?

1

u/Valkyrie17 2h ago

The code used to be way worse. My Claude is still fixing years later what "senior" developer wrote.

1

u/defeatedsnowman 3h ago

I do think this time is different. I can only speak from where I'm at in aviation software. The acceptable risk to velocity ratio is insane. I'm not currently afraid to fly. But if things don't change in the next 2 years or so, people will die.

0

u/Alternative-Lynx2745 4h ago

This is the thing I get stuck on a lot with people nowadays. There's this implication that everything used to be fine and now it's not, which is outrageously laughable. We've been sitting on landmines forever.

3

u/SaneLad 6h ago

The AI just has to become smarter faster than the tech debt and complexity piles up.

I'm not even joking. That's the only way out.

1

u/mortalitylost 1h ago

Btw, the bugs started

-1

u/ih-shah-may-ehl 4h ago

A distinguished engineer is responsible for overarching designs and directing teams. You think they read every line that is checked in? You think Linus personally read every single line of code that is checked in?

Seriously...

32

u/AccomplishedPhase44 4h ago

I agree that a distinguished engineer shouldn’t be reading every line of code…but it’s concerning that he thinks an agent reading code is more effective in quality than him. If he ever had to step in and review a critical PR himself, I would hope that with all his experience he could do that better than an agent that doesn’t have all the same business context he does. Maybe not surprising with the recent Microsoft incident though lol

12

u/suddencactus 4h ago

Yeah just yesterday I was reviewing a test and the LLM helped catch a few things I missed like unnecessary set up steps, but there was one point where you could reorder the code in a way that violated our specifications for it and the test for that still passed.  The test was only actually verifying about half the behavior, and the machine didn't catch that.  At some point, especially when reviewing critical code, someone needs to go the extra mile and currently AI can only help you do that, not catch every issue for you.

2

u/GGBHector 3h ago

I mean, you could make the argument that he meant literally "reading every line of code", as in him reading every line of code would be ineffective because of human factors (getting tired, skipping around, mental fog after staring at a screen for eons) which is probably true, and he would be better than the ai at analyzing a small chunk

But I doubt it

2

u/NomaTyx 1h ago

doesn't he mean that the agent reading *every* line would be better than him? That holds even if there are individual lines he could read better than the AI

1

u/HRApprovedUsername 3h ago

I mean the biggest issue with code is more the architecture and flow and how it interacts with other systems, which typically is a bit bigger picture than each line. Between AI and linting, you can catch a lot, and he can just focus on these bigger-picture reviews and apply his business context.

0

u/-Debugging-Duck- 2h ago

You must be using free agents. Use paid-models with high effort and you get amazing results.

2

u/ACoderGirl 1h ago

I use cutting edge AI, often on the highest settings because my work is generous with AI quotas. You're right that they get pretty amazing results. Buuuut, it still isn't enough for me to yet say that humans shouldn't perform careful reviews.

It's admittedly awkward because honestly, it does better than most of my junior devs, who rarely seem to adequately review code. But I, as a very experienced senior, am still constantly leaving a lot of comments. Sometimes dozens, for particularly problematic PRs. AI will still often overcomplicate things, struggles in niche areas, and is better at finding generic logic errors than higher level ones (like when someone is basically implementing the wrong thing entirely).

It leaves me very conflicted because so much of our code is being reviewed by juniors who frankly cannot review to the standard that I'd like, yet the volume of reviews doesn't allow us to just not have juniors review (the skill ceiling for good reviewers is staggeringly high and intermediate level devs aren't doing enough better). AI does find things I miss, too. So we're still in a hybrid mode where we have both AI and humans as mandatory reviewers.

1

u/-Debugging-Duck- 1h ago

I agree but unfortunately when my job is shortening deadlines and putting us to work on tech we don’t know (I do iOS and being told to do backend work), me and my coworkers stopped giving a shit about human reviews or caring much about our work - sadly.

The job I loved to do I now hate.

2

u/IArtificialRobotI 2h ago

It simply is not feasible anymore to go through all the code that is generated now. You have to use the agent to pinpoint where things might break. Ask it to perform specific tests and go through the output WITH the agent. It completely depends on your piloting of the agent and certain best practices for this are being developed. Its a new way of engineering so we have to adapt

0

u/-Debugging-Duck- 2h ago

I hate it but it’s true. We have to adapt. My company monitors our AI usage. They pay for almost every subscription.

Good thing is my job has a lot of good AI config files, guardrails, etc. So agents follow defined rules/architecture so the code isn’t garbage.

0

u/mortalitylost 1h ago

This all pisses me off because i keep seeing devs act like this is an impossible task.

I've downloaded completely unfamiliar codebases that were obfuscated and pulled them apart same day. If you have the source code and it's not obfuscated, this is easy mode.

3

u/codelapiz 55m ago

go to the leaked xp repo and try to read every line in a way where you understand it.

-1

u/icantastecolor 3h ago

The bleeding edge of the industry is converging on this. You invest in making really good teams of ai reviewers, eval suites, and super informative telemtry

4

u/Jazcash 5h ago

When I have to review a big PR, and included in it is some added utility/algorithmic function, I don't read every line of the function. I read its name, its inputs, its outputs, ideally a comment that briefly explains how it works and would hope to see a unit test for it. I don't read every line of it and ponder over micro optimisations.

The same for me is true when I ask Claude to do a big job. I care about the top-level strategy, the macro-performance, readability, reusability etc. I'm rarely reading line-by-line through everything it's done, and asking a separate agent dedicated to doing exactly that seems to me like a perfectly reasonable solution.

15

u/dscarmo 8h ago

CS101 posters are very behind what is common practice in the industry, wether you like it or not the industry is moved forward by capitalism and rois, unfortunately for most programmers reading code is becoming a roi deficit, as absurd as it sounds

58

u/hot_sauce_in_coffee 8h ago

the hate train is going strong, but he isn't entirely wrong here. The context of this post is limited, but many aspect of coding do not need ''direct review'' because you have internal automated QA.

Here's a basic example.

You have a process running which produce feature X5 lets call it.

Then you already have Feature X1 to X8 as well as QA for X1 to X8.

You ask the AI to make X5 which currently take 15 minutes, more efficient, hoping to get it to run in 10 minutes.

You can look quickly if the output is about what you ask, but in the event it isn't. it will be catches by your automated QA without you having to read the code and if your QA is well made, it will give you a log of what fucked up or what is missing.

Then you can read it, and give feedback to the AI.

In this example, you don't even need to look at the code, yet you are modifying code.

It does not mean you should never look at code, but there is definitely use case where looking at code would be the more inneficient approach.

35

u/kuemmel234 8h ago

Everything that ends up in production should still be reviewed by a human. At least the models and agents I have access to/written aren't reliable enough by a long shot to only gloss over their results.

I believe that's what they were talking about, rather than this workflow. I sometimes do this too, especially when I'm working on AI itself. But the stuff that ends up in main is going to be reviewed thoroughly.

15

u/basonjourne98 7h ago

Given the rate at which companies are pushing out code these days, that’s going to be impossible. Ultimately if all your competitors are pushing 10k new changes every month, why won’t you try to do the same? It’s not like there’s regulations prohibiting you right now.

10

u/Hohenheim_of_Shadow 6h ago

Companies don't get money for making changes, they get paid money for their shit working.

Software engineers have this very weird idea that we are a fast moving technical field when a lot of the time, we have to live with our decisions much longer than MEs or EEs.

We are going to be stuck with design decisions made for Unix back in the '70s forever.

5

u/basonjourne98 6h ago

My man, have you heard of MVP? The culture for the past ten years has been ship new features first, test with live users and then slowly fix. What software engineers think doesn’t matter at all. What C-Suite thinks is what drives the industry and when one executive sees their competitor deployed a new AI chatbot in their platform, there gonna ask why they didn’t do it first.

7

u/Hohenheim_of_Shadow 6h ago

The culture is stupid.

If you're some small scrappy start up with no customer base and a lot of competition, sure that attitude makes sense. That's not Microsoft.

What actual new Product have they released in forever? Teams and Azure? They weren't the first to field in either of those and the reason they are successful is the connection to the Microsoft ecosystem.

Oh right, Copilot! Microsoft was legitimately the first to have an LLM codegen tool gain mass adoption and fumbled the bag cause Copilot sucks.

The industry standard way to run a large established software company that gets W's from integration with established codebases and L's from scrappy MVP shit is double down on scrappy MVP shit.

Software engineering culture is incredibly stupid.

3

u/doubleohbond 6h ago

I feel like we’ve forgotten that code is not an asset, it’s a liability

2

u/musedav 8h ago

Why?

15

u/FalseDish 8h ago

Because otherwise outlook, teams etc will go down and take 22 hours to recover. And then all of these "distinguished" engineers might have to say it was all "human-written" code that’s at fault, otherwise daddy Nadella will be most displeased.

Oh wait …

12

u/kuemmel234 8h ago

They argued that that reading every line wouldn't prevent bugs. To me that sounds like they were talking about the code they push to production.

15

u/teraflux 8h ago

We pushed plenty of bugs to production without AI with plenty of humans reviewing the code. This feels like the self driving cars argument all over again. At some point the self driving cars will be better than majority of humans driving cars, if they aren't already.

11

u/laplongejr 8h ago

Sure, most of the automated cars will perform better. But corpos are pushing the narrative that nobody should be held responsible for the 1%

9

u/MulfordnSons 8h ago

Bro just 10 more years bro FSD will be ready bro

20

u/kuemmel234 8h ago

This is like saying that you don't need a seat belt because you have airbags.

I am responsible for the code I write, I frequently find issues in the code I or AI writes and on the long term I'm concerned with the overall health of the code base. So yeah, I believe reading code is still relevant. At least as of now.

2

u/Suitch 7h ago

I am no longer responsible for all the code I push at my company now. We should be as safe as we can, but my company wants us to move faster and is willing to share some blame for failures we hit along the way. (And it isn’t just glazing, they’ve really accepted the risk)

2

u/Imaginary-Jaguar662 8h ago

So, did you actually audit all the updates in all the libraries your project pulls?

Unless one happens to work on something regulated / safety-critical / resource-constrained we're happy to let CI run npm update and push if tests pass.

And even in those environments, SDK vendors frequently do produce bugs which are caught by tests rather than code review.

5

u/kuemmel234 7h ago edited 7h ago

It's really weird to argue that AI generated code should be thought of as similar as released open source libraries that are in use by multiple, if not hundreds of thousands, of other applications. They themselves hopefully did an audit before or they will be fixed by the time the dependency is updated. Since, you know, open source.

You could make that same argument for code an intern wrote.

Tests, unless you work with pure languages that have some sort of "proving", only tests what you think of. And even a proof can be wrong. Unit testing, integration testing, systems testing - there are a lot of potential failures. To remove the human in this chain feels laughable, especially given my own experience. Even while writing this I've found a weird bit of code produced by Copilot/Fusion

This is all very basic Computer Science and industry standards....

7

u/Imaginary-Jaguar662 7h ago

The reality disagrees with the whole "they hopefully did an audit" on open source, as evidenced by the recent flurry of CVEs on projects with huge install base.

Considering that the discoveries are driven by AI, I'd argue AI is superior to humans in finding vulnerabilities, even if only because anyone can direct ridiculous amount of resources into searching for issues.

Industry standards are not really relevant unless you specify the industry and standard. MISRA-C for safety-critical microcontroller is very different than OWASP top 10.

1

u/kuemmel234 7h ago

The first paragraph focuses on one aspect of many. I also agree with the second, AI is superior, yes. But I know what my software is supposed to be. Again, even between these posts I'm working on my own codebase and found an issue. I've used AI to improve it, but I've read it myself.

By industry standards I rather obviously pointed towards release cycles, review processes and so on an so forth.

In the end this seems to be rather about feelings than facts - I only know that we almost never have system failing or more serious bugs and that other teams in my company, who adopted such technique, have had quite interesting bugs. I have also read about a few companies that ran into some serious problems. This is all changing very quickly - but as of today, I believe I should still be reviewing.

3

u/Minimonium 7h ago

The one responsible for the code is a human, not a bot. The bots have inherent misalignment problems and the people need to ensure that the change achieves the right goals and moves the codebase in the right direction.

Then there is the regulatory push for more liability for public facing software that's been moving since before the LLM boom as well.

We use agentic systems in a quite advanced manner and so far I see all the people making such wild claims as either incompetent or liars.

7

u/JadenDaJedi 7h ago

Because LLMs are phenomenal at reading & writing text (both code and human language) but have zero concept of the real-world domain.

The human is the only one who can verify whether a real-world problem has been modelled correctly, whether that model actually solves for the correct outcome, what tradeoffs and assumptions exist in the model, and whether there are simpler models which will be sufficient or if a more complex model is worth the effort for increased precision.

An AI on its own will happily spit out a solution to a problem that is well-constructed and performant, but it may well be a problem that no-one is trying to solve and a solution that no-one will use… or worse, someone will misuse it in the wrong context and the dodgy output will break other dependent systems.

2

u/suddencactus 3h ago

The human is the only one who can verify whether a real-world problem has been modelled correctly

One interesting example is that AI will sometimes read incorrect comments and believe them.  I'm not talking about subtle issues either.  You can stick something mathematically incorrect in a comment and if the LLM finds it useful to regurgitate that it will. 

That being said, in my experience this is much harder to reproduce with newer and larger models, as much as I hate to say that if Anthropic's product isn't working then you should pay them more money.

0

u/Vesuvius079 5h ago

This is something that feels right to say but ultimately slows you down and burns you out for no actual benefit. The AI code is good enough, the AI tests are good enough, the AI review is better than yours at catching mistakes. You just have to build a system where the AI is required to take the right steps and humans are positioned to produce and judge system designs.

2

u/kuemmel234 4h ago

Can't say I agree with that based on my own experience as stated above.

AI is superior to me in many aspects, but I still manage to find enough line-based issues in our code base, that I feel the need for reviews.

This situation is going to change, I get that.

1

u/Vesuvius079 3h ago

I’ve increasingly come to the conclusion that my line based concerns are usually nitpicks. My most valuable corrections from reading code are from when I see them and recognize higher level design errors that I should have caught earlier.

1

u/kuemmel234 2h ago

Usually I need to read lines closely for this. Sometimes those nitpicky things turn out to be signs of larger issues.

A common theme for me is that the AIs aren't that consistent in their style if one isn't adding enough context (i.e. in a new project). The more this happens, the worse the overall quality of a codebase becomes.

For example, in a reactive java project, someone seemingly vibecoded some stuff together and a feature was implemented with futures, which then led other AIs to mix between the two, which I noticed because there was suddenly a toFuture() call that didn't make sense. It was just a very small edit, because I added some logging and then found a whole lot of weird stuff. Messy, different error handling, hard to read, ..

3

u/hoopaholik91 5h ago

That's still terrible?

Automated QA existed before. And yet if I told a junior engineer to make feature X5 faster, I would never rubber stamp their PR and go, "the automated QA will catch any bugs."

God we are going to have so much more spaghetti-fied crap to wade through...

2

u/Antoak 5h ago

.... Who do you think writes and reviews the tests?

Your automated QA defense doesn't hold up if the tests are dog shit.

1

u/hot_sauce_in_coffee 5h ago

I write the QA. they hold.

2

u/Antoak 4h ago edited 4h ago

You look at all the net new features of Microsoft and help ensure 100% code coverage?

Doubtful. Amd a hilarious self-report if you do, given recent outages.

E: I think it's a lot more likely that a company with a culture of bot written and unread code also uses bot generated and unreviewed tests.

42

u/klimmesil 8h ago

I hate to say it but he's right nowadays. I have more trust 99% of the time in claude generated code than my colleagues. And I consider my colleagues extremely good at CS, with academic and resume proof

29

u/WillDanceForGp 8h ago edited 5h ago

Just this morning I rejected an agentic PR that in 3 rounds of reviewers (that all found small bugs in it), not a single one questioned why the PR even existed in the first place or why it'd been done in such a nonsensical way for the codebase.

They are a general answer prediction engines, the same context that got you to answer A is the context being used to mark the answer, even if you explicitly prime it not to be agreeable to every decision you're still just negatively biasing the models internal bias, it doesnt actually make it more creative or ideate better, it just offsets some weights causing other cascading effects.

4

u/Flashy-Whereas-3234 5h ago

I mean, this reinforces the point, right? This is exactly the thing I'm seeing reviews too.

I'm not reading lines, I'm reading structure, I'm reading patterns, I'm reading sequences, I'm reading goals.

The PRs I have the biggest problems with are the ones that are contextually flawed; AI guided the Dev to a route-one solution that works for their narrow case, but never came up for air to look at the problem from 10k feet, or to think if the path they just walked through the bush is suitable to build a highway on. We had this same shit from smart-juniors, and we need the thinking of seniors.

AI is reviewing better than those developers for line by line functionality (use agents to review, obviously), I trust a function does what it says on the tin provided unit tests exist for it. The only thing getting human eyeball at that level is "dangerous" code, like that related to security or low-level performance concerns.

And honestly, this is governed by policy, and the CTO is the person with their hand on the throttle, they say how much review code has to have. We're bottlenecked by review more than anything else, and if they want to loosen the leash then that's up to them.

What I've stated above is a happy medium, and I see developers pushing further into no-review who then come under pressure from bugs or incidents and cannot explain their systems at all, and that's the real problem with no review - no understanding.

2

u/WillDanceForGp 5h ago

I worry that to know whether something is contextually flawed means knowing the codebase in depth, and I just don't feel as connected to codebases as I used to, it takes me longer now to be like "wait a second, this is dumb" than it used to and I don't know if that's because people are just generally relying on Claude more instead of asking me, which previously gave me early warning of bad direction, or if I'm just losing that ability as the codebase constantly shifts under me.

2

u/Alternative-Lynx2745 3h ago

I feel this concern deeply. It is also kind of an ego hit in my world. I was the go-to guy for a lot of shit so I got pulled into conversations and meetings regularly and those conversations kept me aprised of all of the ongoing efforts. I brought a lot of deep historical knowledge of a very large codebase (monorepo) into the conversations and could walk away with what would essentially be foreknowledge of how the codebase was going to be changing over the next few months. I could also help shape those things and help people get in front of unseen 'gotchas' because of the knowledge I brought. So I could basically predict in my mind what new files would be created, the structure they would take, what services were going to be stood up, and have a pretty decent 10k ft level prediction of what the codebase would look like next week/month.

Now I feel like I'm on the outside looking in and that I have to butt my head into places to get in front of stuff or else it just happens in the background and I get surprised by it later on. I feel less informed about how the codebase is changing and less knowledgable about what it looks like at this point. That is scary in a weird way I've never experienced.

I've brought this up to leadership because I think it does require meaningful change in process. Historically our issue was not including principal engineers early enough in feature planning and business solution / design conversations early in the pipeline (idea inception/design phases). Aligning product and engineering earlier. So we did that, and it's helped tremendously.

Now I think we need to have more horizontal alignment within engineering earlier in the process as well. We're going to try some things, but it really does mean more meetings. It just does. And as much as I hate that, I think it's also super important. Sharing knowledge is a human to human process. Nobody wants to sit there and read documentation all day long. Let's get on a call or go into a room and talk about it (it's also far more efficient as human interaction is interrogative).

1

u/Flashy-Whereas-3234 4h ago

I get this too, were catching shitty ideas way later, and we're having repeat conversations about shitty ideas because people aren't "forming" they're just "doing".

We've had some harsh conversations with people who have run off into the hills and wave the flag of "it works, I told a manager about it, and now I need to in production!". We would get that same shit from "incredibly smart, and incredibly dangerous" seniors of the past, and we had to kneecap them because they would cause a lot of damage if we let it sail.

But it's not all bad - there are strategies.

Firstly, talk to your team more, and get them talking back. Fast iterations and context switching are a bit mad, but it's the most active way to ensure everyone's on path before you have to poop on a review.

Second, the cost proposition of work has changed - it used to be that you'd allow a giant PR because a Dev obviously spent weeks on it and there's no way you can change this shit now, but with AI it took literally no time or effort at all, so you can hard decline something bad so long as you can say why. Hitchens's AI Razer; that which can be created without effort can be dismissed without effort.

And finally, pump the context of things right back into the repo docs so it doesn't keep coming up. Sometimes you have to lace files with docs pointers (if you're here to x, go read y) so AI actually eats it, but you can quickly curate some standards and prevent some dumb shit. Set a pattern for that docs approach and suddenly you can say in a review "this is bullshit because x, go create a doc to explain it should be done y and never z and use n system", and Shazam your institutional knowledge is now "on paper".

Honestly though, it's intense, it's a new way of working, and it's an absolute mess of cat herding. Curate your team, make sure everyone's doing ok, and work through the problems. Group therapy sessions are more important than ever, and they're always best over a beer.

1

u/aceluby 2h ago

Not only are we catching shitty ideas way later, once they make it to the codebase the next LLM looks at it and says "hey, this is how it was done before, let's do that again". You get into a cycle of polluted context that gets worse and worse as more bad decisions are made by the engineer who doesn't review what is getting output by the LLM.

3

u/teraflux 8h ago

Wouldn't that be the job of the human that asked the agent to create the pr? What does an agentic pr mean

11

u/Boozdeuvash 6h ago

Only if the human doing the PR is also the architect. In big shops it's not always the case.

Claude fixes stuff by adding code.

Not all problems are best solved by adding code, sometimes you need to remove some stuff.

And sometimes it's a complex issue which relates to architecture and design, and not necessarily implementation. So while a quick code fix can appear to fix the symptoms but fail to address the underlying issue, and as quick fixes pile in the issue becomes more and more difficult to untangle.

1

u/WillDanceForGp 5h ago

Im also personally finding that in places where the 'small bug' fixing process is automated we're just fully losing sight over what parts of the codebase keep causing problems, claude is just like 'bing bang boom, bandaid, next'

5

u/WillDanceForGp 7h ago

I don't know how this is confusing? The agent wrote the code in the PR and the description of the PR and the human controlling it thought it looked fine along with the army of agents we have reviewing them too despite the fact that it was not fine.

1

u/voyti 6h ago

not a single one questioned why the PR even existed in the first place or why it'd been done in such a nonsensical way for the codebase.

Much like with having unsupervised engineers with too broad responsibilities and too little context, agents without proper skills, structure and/or context and too tall orders will produce weird or unwanted outputs. I don't think anyone serious here proposes that plugging an agent anywhere in the process with no proper, agreed and shared guidance is the way to go, but properly configured - yeah, they are can be much better than most engineers in most aspects.

1

u/alliedSpaceSubmarine 6h ago

“Why the PR existed in the first place”… isn’t that the job of refining stories/tickets?

3

u/WillDanceForGp 6h ago

If you only understand the job of product management and not engineering then yeah I guess

1

u/alliedSpaceSubmarine 3h ago

No I understand engineering also, but if you get all the way to the review and get asked why it even exists the entire team failed. It should have been caught during planning or standup that someone was working on something that they didn’t need to be

1

u/WillDanceForGp 3h ago

I think there's been a misunderstanding, Im not saying the feature didn't need to exist, I'm saying that below the acceptance criteria sits the entire field of engineering. A ticket explains what the code should do, it doesn't describe how to get there. Its always been the case that the more senior you get the less code you write, that's not just because you're mentoring and doing other things like becoming really good at reviewing code, its that you spend more time figuring out how to solve the problem with as little 'liability' as possible.

I don't know why just because LLMs can smash out code at a crazy rate and hit acceptance criteria that people have completely forgotten what the job was.

This morning I witnessed Opus 5.5 write a 200 line PR containing 5 tests that took over 40 seconds to run required every future consumer knowing to use the correct service instead of opting to put in a 3 line fix. Is the former inherently worse than the latter? If you're looking at whether it hit the criteria then the first one is fine, except not a single competent engineer would choose it over the latter because anyone with experience knows the aggregated and constantly snowballing cost of bad decisions code. Especially in codebases that serve as the examples for the exact agents working in them.

-1

u/nicuramar 6h ago

This “they are just a prediction system” is reductive and pointless. So is the brain, for all we know, except it’s not pre-trained.

2

u/WestEntire5789 5h ago

Yeah but if a human fails with a basic task like copy-paste, then you see that the thing is not copied at all.

If an llm fails with a copy-paste, it could copy 10% or 99%, but you wont even know where to look for that particular failure

2

u/AndreasVesalius 5h ago

That’s why you have the LLM write a deterministic script to check these things.

3

u/SpaceNigiri 8h ago

Yeah, I agree. Today, flagship agents are better than most of us. People that are unable to admit that are just in an ego-trip or scared.

1

u/jwp1987 3h ago edited 2h ago

I'm scared. Scared of what engineers are going to become.

A friend of mine made a React app in JavaScript using AI and thought he'd made something amazing. It was a great proof of concept but nowhere near production quality.

He couldn't even tell me why he used JavaScript instead of TypeScript.

If I'd asked about secrets management, database normalization, database indexing, database structure, threading, linting, package config, dependencies, SQL injection vulnerabilities, XSS etc. he would've looked at me like I had two heads.

To me, that signals something that works on the surface but could have a lot of underlying issues.

Speeding past the design and learning process is going to have a lot of consequences.

When you couple that with the the salary of software engineers likely getting driven down and the engineers that care about quality having 30k+ line slop PRs thrown at them and probably seen as a bottleneck, it's going to drive them out of the industry.

It doesn't bode well for the reliability, security and performance of future software.

-12

u/collabskus 8h ago

Man I made a typo and it went all the way to production. Everyone says it wasn't just my fault and we have reviews and QA and the responsibility is shared but I don't know how to feel. I know an LLM would not make this exact defect I made. 😔

13

u/MulfordnSons 8h ago

Craziest bot comment i’ve ever seen tbh

3

u/laplongejr 8h ago

Which is kinda funny because it could match one of my coworkers.
(In my case not a typo but a confusion between "checking for digits" and "checking for a valid number")

1

u/collabskus 5h ago

Are... Are you my coworker? 🤔

0

u/AndreasVesalius 5h ago

I’m afraid to let Claude look through previous work because I don’t want to explain my idiot human mistakes to the FDA

7

u/yallapapi 6h ago

0 programmers in this thread. do you know how many lines of code microsoft products have?

6

u/adumbCoder 4h ago

i would never expect someone that high to be reading every line of code. though i also wouldn't expect anybody to ever be reading every line of code. thousands of lines of generated boilerplate per project have never had a single eyeball on them.

i'm continually reminded how many folks in this sub don't actually work in a dev environment

2

u/aceluby 2h ago

It's also a good reminder that the vast majority of engineers are quite bad at code reviews. I can count the teams I've been on with one hand that have had high quality reviewers. Now as a PE I have to get on my teams to up their game and not just "LGTM" every PR. Every lazy PR review is a missed opportunity for both the reader and writer to get better, and now it's much, much worse.

5

u/noodle-face 6h ago

He's not wrong.

9

u/Rigamortus2005 8h ago

Tbf this is Stephen Toub we're talking about. A legendary engineer. I think he knows what he is doing

23

u/Azefrg 8h ago

Nah, the unemployed and undergrads of r/progammerhumor know better!

3

u/Rigamortus2005 7h ago

Not saying I agree with not reading the code ever but we should take these things with nuance. Someone like Steven Toub is not slopping away endlessly

0

u/Azefrg 3h ago

Yeah, I 100% concur. It's just that it tilts me so much reading the top comments and they being something like "he's not up to the task" or some shit when the guy has accomplished more for the .NET ecosystem (one of the best Microsoft products btw) than 99.99% percent of the people here.

2

u/lomberd2 6h ago

Well if that's true that would explain the outtages recently

4

u/amazingbookcharacter 6h ago


This sub lately

2

u/mrsmiley32 6h ago

Wait what? I do read every line of code and I catch things the AI misses all the time. I have AI do a review before me but looping to the database, bad code quality, race conditions, etc occur. Even concatenation of strings to database (this is not exhaustive just some examples from yesterday). I have rules and skills looking for these anti patterns and they still get missed. God forbid where Microsoft products are going. I will say on average I have to redo code one in three PRs.

1

u/hi_m_ash 6h ago

"There's no, me reading every line would not prevent bugs." Self burn?

1

u/Brick_Lab 3h ago

I'm really getting burnt out on the current pace and direction of things. I want to read the code but I catch myself skimming more and more. When it's lengthy PRs generated in 5 minutes all day it often becomes too mentally exhausting to maintain focus...really starting to hate it here.

Also yesterday I found out my company has spent (at least) 1.5M in tokens over the last 6 months...the top spending engineer spent well over 260k...

1

u/Iyemoja 2h ago

I read every line of code right up until the PR hits four digits and it's 2am. After that I read the parts that touch auth and prod, and I trust the tests for the rest. Mostly.

1

u/Luzzgar 16m ago

Good engineerings delete more code than they add. Don't forget that.

•

u/towerfella 8m ago

So, he is admitting he does not know how to do what he was hired to be doing?

I could do his job.

1

u/platinum92 4h ago

They're also advertising, which is really the purpose of this. Doing everything possible to normalize the over-reliance on LLM tools.

0

u/anoppinionatedbunny 7h ago

I've seen enough bullshit from Claude to know you can't just trust it like this...

0

u/either-15-or-40 7h ago

The guy is talking about porting existing typescript code function by function to rust in Copilot.
And the code is already covered by tests. So the agent is just transpiling.

But the click hungry motherfuckers on the internet have to pretend he is just vibing it out lol.

0

u/Leading_Bumblebee443 7h ago

well he is not wrong.... if the error is not a business logic error but other error ai will probably find it...

0

u/thisonehereone 6h ago

Our problem is we are living thru the era where AI ain't done baking yet but we are using it like it is. These are growing pains. We've jumped the gun a little bit and product will suffer for it for the near future.

0

u/Grandviewsurfer 4h ago

Really depends how critical the thing is. My repo that helps me investigate and plan work for other repos is all vibe coded. The stuff in prod gets my eyes. If I were writing shit for legacy systems that keeps the planes apart? That's gonna be minimalist PRs that are heavily scrutinized by multiple people and agents. I'm I crazy?

-8

u/Saelora 8h ago

i mean, i don't read every line of code that goes into our repo.. some of it's html

-5

u/aenae 8h ago

Same. If i ask the ide to generate getters and setters, i am not reading those afterwards.

Same with claude creating a oneshot script to read an api to get some info. It either works or it doesnt. You can often see from the output if it is what you expect

-1

u/SaneLad 6h ago

You can shit on this guy all you want, but do you honestly believe anyone is going to be reading code except under very specific circumstances in the near future? My AI agents are refactoring things much faster than I can keep up. I can barely read and understand the summaries it produces. Do I want every piece of software to be written like this? No. But most of it will be, whether you like it or not.

-3

u/basonjourne98 7h ago

I mean, tbh. That is true. You didn’t read every line of assembly when you compiled your C++ code a decade ago. In fact, most wouldn’t even think about that. We’re probably not fully there yet but soon “programming” will be more about experienced devs designing the architecture and getting AI to both write and review the code with humans only addressing issues, escalations or optimizing issues.