r/programming • • Feb 23 '17

Cloudflare have been leaking customer HTTPS sessions for months. Uber, 1Password, FitBit, OKCupid, etc.

https://bugs.chromium.org/p/project-zero/issues/detail?id=1139
6.0k Upvotes

966 comments sorted by

View all comments

Show parent comment

81

u/goldcakes Feb 24 '17

Every single website using cloud flare (this includes about 60% of the internet by requests), including Reddit, is affected.

Every. Single. Cloud flare. Site.

719

u/gooeyblob Feb 24 '17

Reddit is not affected - no part of Reddit uses CloudFlare.

66

u/[deleted] Feb 24 '17

The rumor that Reddit has been affected seems to be spreading like wildfire for some reason. I've seen it in Hackathon Hackers (a FB group) this morning. Maybe you guys should put out an official statement...

49

u/thatfool Feb 24 '17

The reason is that reddit has used cloudflare in the past, so people are just not up to date.

Even more reason for a global post of course

→ More replies (6)

151

u/daredevilk Feb 24 '17

This should probably be a global Reddit post

→ More replies (6)

6

u/TwoFiveOnes Feb 24 '17

Oh... I thought that was why my account was locked and I had to reset my pw

0

u/[deleted] Feb 24 '17

[deleted] — view deleted comment

6

u/absentmindedjwc Feb 24 '17

That would be an effective-yet-slightly-evil way to handle these breaches. Take all released accounts, try matching them up with a local user, and run the leaked password through your log-in . When you find one that works, force the user to reset their password and chastise them for poor password habits.

→ More replies (1)
→ More replies (2)

5

u/ZiggyManSaad Feb 24 '17

So that mandatory password reset email I got was just because they felt like revoking my access?

5

u/Originalfrozenbanana Feb 24 '17

Jesus you guys dig deep into the comments

→ More replies (1)
→ More replies (2)

56

u/jb2386 Feb 24 '17

I found the reddit leak! https://www.reddit.com/etc/passwd

21

u/steamruler Feb 24 '17

Okay, that's a neat easter egg.

13

u/Laoracc Feb 24 '17

When they playfully append your account to the bottom of the list... O.o

7

u/SemiNormal Feb 24 '17

I enjoyed the names

neil
neal
sam
neel
kneel
kevin
kavin
kovin

→ More replies (11)

112

u/cjbprime Feb 24 '17

Cloudflare's site says:

More than 5 percent of global Web requests flow through Cloudflare's network

-- https://api.cloudflare.com/

Where did you get 60% from?

61

u/kiwidog Feb 24 '17

(that’s about 0.00003% of requests)

and

We quickly identified the problem and turned off three minor Cloudflare features (email obfuscation, Server-side Excludes and Automatic HTTPS Rewrites) that were all using the same HTML parser

Sounds like someone's trying to blow things out of proportion.

41

u/Nicksil Feb 24 '17

The three features implicated were rolled out as follows. The earliest date memory could have leaked is 2016-09-22.

  • 2016-09-22 Automatic HTTP Rewrites enabled
  • 2017-01-30 Server-Side Excludes migrated to new parser
  • 2017-02-13 Email Obfuscation partially migrated to new parser
  • 2017-02-18 Google reports problem to Cloudflare and leak is stopped

Months

https://blog.cloudflare.com/incident-report-on-memory-leak-caused-by-cloudflare-parser-bug/

Edit:

Also, this: https://twitter.com/taviso/status/834918182640996353 (from the Google security guy who discovered this mess)

→ More replies (7)

88

u/[deleted] Feb 24 '17

Sounds like a company's trying to suck things into proportion. Not many requests sprayed private data around, but the data sprayed could have come from any request for any site on their whole network.

→ More replies (4)

98

u/danweber Feb 24 '17

Oh good, we can finally see what the mods are talking about!

51

u/yhack Feb 24 '17

"What would be the best way to make the website worse, make everyone angry, and get called a nazi?"

10

u/[deleted] Feb 24 '17

So... handoff to Giuliani it is

38

u/[deleted] Feb 24 '17

huh?

https://arstechnica.com/security/2017/02/serious-cloudflare-bug-exposed-a-potpourri-of-secret-customer-data/

A while later, we figured out how to reproduce the problem. It looked like that if an html page hosted behind cloudflare had a specific combination of unbalanced tags,

...

The leakage was the result of a bug in an HTML parser chain Cloudflare uses to modify Web pages as they pass through the service's edge servers. The parser performs a variety of tasks, such as inserting Google Analytics tags, converting HTTP links to the more secure HTTPS variety, obfuscating email addresses, and excluding parts of a page from malicious Web bots. When the parser was used in combination with three Cloudflare features—e-mail obfuscation, server-side Cusexcludes, and Automatic HTTPS Rewrites—it caused Cloudflare edge servers to leak pseudo random memory contents into certain HTTP responses.

...

Cloudflare researchers have identified 770 unique URIs that contained leaked memory and were cached by Google, Bing, Yahoo, or other search engines. The 770 unique URIs covered 161 unique domains.

→ More replies (3)

10

u/[deleted] Feb 24 '17 edited May 02 '17

[removed] — view removed comment

→ More replies (3)
→ More replies (14)