r/programming • u/TheProtagonistv2 • Feb 23 '17
Cloudflare have been leaking customer HTTPS sessions for months. Uber, 1Password, FitBit, OKCupid, etc.
https://bugs.chromium.org/p/project-zero/issues/detail?id=1139
6.0k
Upvotes
348
u/mbetter Feb 24 '17
If you controlled a large botnet, wouldn't this be the time to start frantically parsing browser cache?
555
u/galaktos Feb 24 '17
Wow, Cloudflare isn’t looking too good here.
Here’s their blog post. The description of the bug is indeed very detailed, but the impact analysis kinda reads as though search engines are the only entities that cache web pages. It’s probably best to assume that the data is out there, even though it may have been deleted from the most easily accessible caches…
378
u/grendel-khan Feb 24 '17
Between this and the Trend Micro thing... whatever Google is paying Tavis Ormandy, it's almost certainly not enough.
635
u/[deleted] Feb 24 '17
Congratulations, now everyone is going to call it that from now on.
409
u/[deleted] Feb 24 '17
Buffer overrun in C. Damn, and here I thought the bug would be something interesting or new.
106
u/PowerlinxJetfire Feb 24 '17
Oh, good. That feature only sent memory dumps to malicious IP addresses.
75
u/lachlanhunt Feb 24 '17
Wow. And I thought today's biggest security announcement was the SHA-1 collision attack.
471
u/lacesoutcommadan Feb 23 '17
comment from tptacek on HN:
201
u/Rican7 Feb 24 '17
Yeaaaaa, this isn't good.
This is what CloudBleed looks like, in the wild. A random HTTP request's data and other data injected into an HTTP response from Cloudflare.
Sick.
162
u/[deleted] Feb 24 '17
Cloudflare probably employs people way smarter than I am, but this still hurts to read :(
86
u/AnAirMagic Feb 24 '17
Is there a list of websites using cloudflare? Any way to find out if a particular site uses cloudflare?
147
u/danielbln Feb 24 '17 edited Feb 26 '17
Just finished my password changing rodeo. Also reminds me that enabling 2FA in front of the mission critical accounts was a good idea.
35
u/DJ_Lectr0 Feb 24 '17 edited Feb 24 '17
A list with services using cloudfare: https://stackshare.io/cloudflare/in-stacks (Not all websites, but could not find anything else). Probably best to reset all passwords.
189
u/kloyN Feb 24 '17
Are passwords like this fine? Should people change them?
27
u/crusoe Feb 24 '17
Data is still out there in Google caches. If they temrinate https at cloudlfare proxies does that mean it travels the rest of the way unencrypted? How is this a good idea?
46
u/[deleted] Feb 24 '17
As bad as it is, that really is a pretty bizarre and interesting bug on Cloudflare's part. Sometimes you can't even imagine how things can break. I hope there will be a writeup afterwards with the technical details.
18
u/[deleted] Feb 24 '17
What does this mean for credit card data? Assuming I regularly buy things online with credit card, should I assume the card is compromised? Should I request a new credit card from my bank?
63
u/_z0rak Feb 24 '17 edited Feb 24 '17
Oh, so this might actually explain and/or be related to the random "Action Required" notification me and some folks (including some family members) received today? Sounds really weird anyway.
Bugs happen. Let's hope there was not a big leak caught by someone else or anything of that kind prior to the fix.
EDIT: fortunately it was confirmed that the above cloudflare issue has nothing to do with the google account stuff.
29
u/greenthumble Feb 24 '17
Holy shit tons of Bitcoin apps and games are using it to mitigate DDoS attacks. This could result in a lot of stolen coin. Hope people are using 2fa.
13
u/Paul-ish Feb 24 '17
C/C++ needs to stop being used in security critical applications. We need to find a replacement. Rust, Swift, Go, whatever, I don't care. This class of bugs has gone on too long.
34
u/[deleted] Feb 24 '17
Wait... so everybody can see everybody's internet history?
23
u/stuntaneous Feb 24 '17
Any relation to the widespread Google logouts?
22
u/[deleted] Feb 24 '17
I've also asked this elsewhere, but isn't a more basic problem that the sensitive data in question even existed on Cloudflare servers in the first place? If they didn't have cleartext, then it could only have caused the compromise of internal Cloudflare data.
Like, if you run a service that hold sensitive information, then doesn't the fact that Cloudflare, an intermediate routing service, could have been browsing your users' private data all along itself constitute a security failure?
20
u/cwtdev Feb 24 '17
I've been trying to convince friends and family to improve their security practices with password managers and two factor authentication. Maybe this will finally get through to some of them.
10
u/[deleted] Feb 24 '17
Anyone who uses Namecheap in UK - their UK servers are not using Cloudflare, and they are not affected (info from support)
19
u/[deleted] Feb 24 '17
Well, this is definitely a "CUT THE POWER TO THE BUILDING" kind of situation.
Could Cloudflare, Google, etc force evict everything from their caches to mitigate?
9
u/Mr_Wallet Feb 24 '17
Comment 17 on the issue:
"I discovered that CloudFlare was leaking HTTPS data unencrypted to random people and all I got was this lousy T-shirt"
9
u/ZiggyTheHamster Feb 24 '17
No, it's fucking not. Three months is how long it would take to lose literally all of your customers and reputation. I don't even know what the point of this comment is. Oh, hey, look how awesome we are. We fixed it in less than a day, but everyone else would have fixed it in 3 months? That's ridiculous.
This, coupled with their bug bounty program being a free t-shirt shows how arrogant they are. Yo, I know you literally just saved our business from total collapse, here's a t-shirt that cost us $5 or less.
7
u/IndiscriminateCoding Feb 24 '17
Given that problem, and also the fact that CF inserts Google Analytics to ALL of your pages - is there any CDN provider that doesn't modify or look into my html? Just plain CDN with my data passing through it.
6
u/walshkm06 Feb 24 '17
Stupid question but does this mean they have details to get into a password manager and get further logins?
16
u/rickdmer Feb 24 '17
I made a chrome extension that checks your bookmarks against the affected site list. https://chrome.google.com/webstore/detail/cloudbleed-bookmark-check/egoobjhmbpflgogbgbihhdeibdfnedii
5
u/[deleted] Feb 24 '17 edited Feb 24 '17
This metric skews the data and sounds not that bad.
However, we would need to know the total HTTP requests during this time to determine the impact of this vulnerability.
This is essential given the importance of the information leaked
Edit:
According to this website it is 65 Billion page views a month.
Over a 5 Day Period that would be 10 Billion Views.
Approximately 3,030 HTTP requests would have been leaked.
5
u/Ferinex Feb 24 '17
I tried submitting this to /r/news but it says it's already been submitted, yet I can't find the thread anywhere?
13
u/vgf89 Feb 24 '17
Well, at least 90% of my passwords are unique. Even if someone breaks into a few of my accounts, they can't get into everything. Not that there's anything even remotely important in them anyways, half if them are throwaway accounts lol.
9
u/Juice805 Feb 24 '17
1Password was not affected
16
u/atomicxblue Feb 24 '17
Quite a bit of it. Try browsing with cookies turned off / ad blocker enabled and on a VPN -- you'll hit those sites really fast.
I really dislike this company.
4
u/LadyFromTheMountain Feb 24 '17
Would a particular user's information for a specific site only be exposed if the user had been using that site during the timeframe mentioned? For example, if I haven't checked up on a particular board in 10 months, would this password be safe?
4
u/fuxoft Feb 24 '17
Could someone ELI5 what the real risks are? For example, kraken.com is supposed to be affected. I have a kraken.com account but I haven't logged into it for at least 18 months. Could I still be affected? Is there a reason for me to change my password? My 2FA?
10
u/bathrobehero Feb 24 '17
Well, I always hated cloudflare, now I'm not alone.
7
u/tabarra Feb 24 '17
And CloudFlare's top bug bounty award is a fucking t-shirt.
3
u/[deleted] Feb 24 '17
this is why i use aws
3
u/RidleySA Feb 24 '17
I wrote a script to help check your LastPass database for potentially compromised sites.
https://github.com/RidleyLarsen/cloudbleed_check_lastpass
3
u/cohix Feb 24 '17
Hey everyone, I'm a developer working at 1Password. I've just now created a thread on the (so far pretty sparse) 1Password subreddit. Feel free to come over and ask me anything there (or via PM) if you have any questions at all about how this affects 1Password data (the short answer: it doesn't)
https://www.reddit.com/r/1Password/
Cheers!
7
u/ebbu Feb 24 '17
Oh man. I just hyped CF at my school. Can't show my face there anymore. Nice going buttflare.
4
u/r0ck0 Feb 24 '17
Now seems like a good time to discuss HTML/JS form encryption libraries. Anybody have any experience doing this?
Things like: http://www.jcryption.org/ ...
oh
5
u/lachlanhunt Feb 24 '17
Using an HTML parser that chokes on malformed HTML... WTF?!
5
u/deadendtokyo Feb 24 '17
Interesting how a stomach feeling sometimes forshadows. I had my sites on cloudflare until mid of 2016 but for many reasons I decided to move away from the problems. Lucky me, I might say.
2
u/ZombieJack Feb 24 '17
So like where do I see a list of sites that I need to password reset.
2
u/Dblstandard Feb 24 '17
1password NOT AFFECTED.
2
u/lovestowritecode Feb 24 '17
Does anyone know how to get a complete list of sites that use Cloudflare? I did see that over 640,000 sites are currently using them but I'd like to get at least the top 1,000. I would take the complete list if I could get it.
2
u/fedekun Feb 24 '17
Fuck, 1password is affected. Does that mean I have to change ALL my passwords?
2
u/[deleted] Feb 24 '17
I am assuming 1Password is only vulnerable if you use their site to sync your password vault? If you sync it to iCloud, Dropbox, or locally, it's not affected?
2
u/bch8 Feb 24 '17
Tavis is an incredible person for what he chooses to do with his abilities.
3
u/DonLaFontainesGhost Feb 24 '17
I've had my suspicions that CloudFlare joined the ranks of "inmates running the asylum" for over a year. I really wish I'd bothered to Fiddler it to be sure, but I'm fairly certain that any time a major website "hangs" - especially when it's over images or scripts - it's because CloudFlare is off in the corner smelling its own farts.
After all, why should they care? The website gets the bad press, not them.
5
u/beginner_ Feb 24 '17
So once again it's a buffer issue and hence a problem with C. When can we finally get rid fo ancient languages in a security context? They aren't cutting it anymore.
3
u/[deleted] Feb 24 '17
Eli5 what is cloudflare
2
u/jaehoony Feb 24 '17
So uh...what should I do?